Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Fri, 2016-09-23 at 00:39 +0200, becher.jan...@gmail.com wrote: > On Thu, Sep 22, 2016 at 03:05:02PM -0700, Joe Perches wrote: > > On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > > >r emoved a space after a cast to obtain the coding style. > > Better would be to change the subject to

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Fri, 2016-09-23 at 00:39 +0200, becher.jan...@gmail.com wrote: > On Thu, Sep 22, 2016 at 03:05:02PM -0700, Joe Perches wrote: > > On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > > >r emoved a space after a cast to obtain the coding style. > > Better would be to change the subject to

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 03:05:02PM -0700, Joe Perches wrote: > On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > > removed a space after a cast to obtain the coding style. > > Better would be to change the subject to something like: > > [PATCH] staging: wlan-ng: Remove unnecessary spaces

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 03:05:02PM -0700, Joe Perches wrote: > On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > > removed a space after a cast to obtain the coding style. > > Better would be to change the subject to something like: > > [PATCH] staging: wlan-ng: Remove unnecessary spaces

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. Better would be to change the subject to something like: [PATCH] staging: wlan-ng: Remove unnecessary spaces before casts

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 23:56 +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. Better would be to change the subject to something like: [PATCH] staging: wlan-ng: Remove unnecessary spaces before casts

[PATCH] drivers: wlan-ng: fixed a coding style issue

removed a space after a cast to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/p80211netdev.c | 12 ++-- drivers/staging/wlan-ng/p80211req.c| 16

[PATCH] drivers: wlan-ng: fixed a coding style issue

removed a space after a cast to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/p80211netdev.c | 12 ++-- drivers/staging/wlan-ng/p80211req.c| 16 drivers/staging/wlan-ng/prism2fw.c

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > So you think I should make one "big" patch and resend it?

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > So you think I should make one "big" patch and resend it?

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 22:52 +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > > So you think I should make one "big" patch and resend it? Make

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 22:52 +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > > So you think I should make one "big" patch and resend it? Make

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 11:32:02PM +0300, Andrey Utkin wrote: > On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > > removed a space after a cast to obtain the coding style. > > > > Signed-off-by: Jannik Becher > > --- > >

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 11:32:02PM +0300, Andrey Utkin wrote: > On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > > removed a space after a cast to obtain the coding style. > > > > Signed-off-by: Jannik Becher > > --- > > drivers/staging/wlan-ng/p80211req.c | 2 +- > > 1 file

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. > > Signed-off-by: Jannik Becher > --- > drivers/staging/wlan-ng/p80211req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. > > Signed-off-by: Jannik Becher > --- > drivers/staging/wlan-ng/p80211req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] drivers: wlan-ng: fixed a coding style issue

removed a space after a cast to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/p80211req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c

[PATCH] drivers: wlan-ng: fixed a coding style issue

removed a space after a cast to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/p80211req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c index 40627d5..ecd2fff

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 20:01 +0200, Jannik Becher wrote: > changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding > style. Hello. Please always use Greg KH's latest staging-next branch (or -next) to make these sorts of changes.  This one has already been done.

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, 2016-09-22 at 20:01 +0200, Jannik Becher wrote: > changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding > style. Hello. Please always use Greg KH's latest staging-next branch (or -next) to make these sorts of changes.  This one has already been done.

[PATCH] drivers: wlan-ng: fixed a coding style issue

changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c

[PATCH] drivers: wlan-ng: fixed a coding style issue

changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding style. Signed-off-by: Jannik Becher --- drivers/staging/wlan-ng/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index