Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-08 Thread Tomeu Vizoso
On 8 August 2016 at 12:43, Yakir Yang wrote: > + Archit > > Tomeu, > > Thanks for the update :-) > > But you have missed three tiny align problems, please see my inline notes, > wish you could fix them. After that this patch looks good to me, so: > > Reviewed-by: Yakir Yang Hi Yakir, thanks fo

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-08 Thread Yakir Yang
+ Archit Tomeu, Thanks for the update :-) But you have missed three tiny align problems, please see my inline notes, wish you could fix them. After that this patch looks good to me, so: Reviewed-by: Yakir Yang I guess this patch should go through Archit's drm_bridge tree, so I added him

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-05 Thread Sean Paul
On Fri, Aug 5, 2016 at 8:59 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use them inst

[PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-05 Thread Tomeu Vizoso
Remove code for reading the EDID and DPCD fields and use the helpers instead. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Tested-by

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
Tomeu, o_O Ignore my previous email, seems I make a mistaken about the email format, and mess up the patch format. I have move my previous comments to this one :-) On 08/04/2016 02:23 PM, Tomeu Vizoso wrote: Remove code for reading the EDID and DPCD fields and use the helpers instead. Besi

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
Tomeu, Nice job ! Have a few nits bellow. ;) On 08/04/2016 02:23 PM, Tomeu Vizoso wrote: Remove code for reading the EDID and DPCD fields and use the helpers instead. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be go

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-04 Thread Sean Paul
On Thu, Aug 4, 2016 at 2:23 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use them inst

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-04 Thread Javier Martinez Canillas
Hello Tomeu, On 08/04/2016 02:23 AM, Tomeu Vizoso wrote: > Remove code for reading the EDID and DPCD fields and use the helpers > instead. > > Besides the obvious code reduction, other helpers are being added to the > core that could be used in this driver and will be good to be able to > use the

[PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-03 Thread Tomeu Vizoso
Remove code for reading the EDID and DPCD fields and use the helpers instead. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Cc: Javie