Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-14 Thread Inki Dae
On 2014년 10월 10일 21:39, Andrzej Hajda wrote: > On 10/02/2014 12:52 PM, Inki Dae wrote: >> On 2014년 10월 02일 17:58, Joonyoung Shim wrote: >>> Hi Andrzej, >>> >>> On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished.

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-14 Thread Inki Dae
On 2014년 10월 10일 21:39, Andrzej Hajda wrote: On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-10 Thread Andrzej Hajda
On 10/02/2014 12:52 PM, Inki Dae wrote: > On 2014년 10월 02일 17:58, Joonyoung Shim wrote: >> Hi Andrzej, >> >> On 10/01/2014 05:14 PM, Andrzej Hajda wrote: >>> The patch disables vblanks during dpms off only if pagefilp has >>> not been finished. It also replaces drm_vblank_off with

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-10 Thread Andrzej Hajda
On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. It

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Alexandre Courbot
On Thu, Oct 9, 2014 at 7:08 PM, Thierry Reding wrote: > On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: >> On 10/02/2014 08:52 PM, Andrzej Hajda wrote: >> >Hi, >> > >> >+CC possible victims >> > >> >On 10/02/2014 12:52 PM, Inki Dae wrote: >> >>On 2014년 10월 02일 17:58, Joonyoung

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Thierry Reding
On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: > On 10/02/2014 08:52 PM, Andrzej Hajda wrote: > >Hi, > > > >+CC possible victims > > > >On 10/02/2014 12:52 PM, Inki Dae wrote: > >>On 2014년 10월 02일 17:58, Joonyoung Shim wrote: > >>>Hi Andrzej, > >>> > >>>On 10/01/2014 05:14 PM,

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Thierry Reding
On Thu, Oct 09, 2014 at 09:52:58AM +0100, Russell King - ARM Linux wrote: > On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: > > But there might be another issue, which is that calls to > > drm_vblank_get() will return -EINVAL if invoked between drm_blank_off > > and

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Russell King - ARM Linux
On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: > But there might be another issue, which is that calls to > drm_vblank_get() will return -EINVAL if invoked between drm_blank_off > and drm_blank_on. Is this really the desired behavior? Can it at least > happen? If so, how

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Russell King - ARM Linux
On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: But there might be another issue, which is that calls to drm_vblank_get() will return -EINVAL if invoked between drm_blank_off and drm_blank_on. Is this really the desired behavior? Can it at least happen? If so, how are

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Thierry Reding
On Thu, Oct 09, 2014 at 09:52:58AM +0100, Russell King - ARM Linux wrote: On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: But there might be another issue, which is that calls to drm_vblank_get() will return -EINVAL if invoked between drm_blank_off and drm_blank_on.

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Thierry Reding
On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: On 10/02/2014 08:52 PM, Andrzej Hajda wrote: Hi, +CC possible victims On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Alexandre Courbot
On Thu, Oct 9, 2014 at 7:08 PM, Thierry Reding tred...@nvidia.com wrote: On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: On 10/02/2014 08:52 PM, Andrzej Hajda wrote: Hi, +CC possible victims On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-08 Thread Alexandre Courbot
On 10/02/2014 08:52 PM, Andrzej Hajda wrote: Hi, +CC possible victims On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-08 Thread Alexandre Courbot
On 10/02/2014 08:52 PM, Andrzej Hajda wrote: Hi, +CC possible victims On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Andrzej Hajda
Hi, +CC possible victims On 10/02/2014 12:52 PM, Inki Dae wrote: > On 2014년 10월 02일 17:58, Joonyoung Shim wrote: >> Hi Andrzej, >> >> On 10/01/2014 05:14 PM, Andrzej Hajda wrote: >>> The patch disables vblanks during dpms off only if pagefilp has >>> not been finished. It also replaces

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Inki Dae
On 2014년 10월 02일 17:58, Joonyoung Shim wrote: > Hi Andrzej, > > On 10/01/2014 05:14 PM, Andrzej Hajda wrote: >> The patch disables vblanks during dpms off only if pagefilp has >> not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. >> It fixes issue with page_flip ioctl

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Joonyoung Shim
Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: > The patch disables vblanks during dpms off only if pagefilp has > not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. > It fixes issue with page_flip ioctl not being able to acquire vblank counter. This problem

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Joonyoung Shim
Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. It fixes issue with page_flip ioctl not being able to acquire vblank counter. This problem

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Inki Dae
On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. It fixes issue with page_flip ioctl not being

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Andrzej Hajda
Hi, +CC possible victims On 10/02/2014 12:52 PM, Inki Dae wrote: On 2014년 10월 02일 17:58, Joonyoung Shim wrote: Hi Andrzej, On 10/01/2014 05:14 PM, Andrzej Hajda wrote: The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with

[PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-01 Thread Andrzej Hajda
The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. It fixes issue with page_flip ioctl not being able to acquire vblank counter. Signed-off-by: Andrzej Hajda --- Hi Inki, This is fix (or just workaround)

[PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-01 Thread Andrzej Hajda
The patch disables vblanks during dpms off only if pagefilp has not been finished. It also replaces drm_vblank_off with drm_crtc_vblank_put. It fixes issue with page_flip ioctl not being able to acquire vblank counter. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- Hi Inki, This is fix (or