Re: [PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-11 Thread Kees Cook
On Mon, Mar 11, 2013 at 4:03 PM, Daniel Vetter wrote: > On Sun, Mar 10, 2013 at 02:10:06PM -0700, Kees Cook wrote: >> This replaces the manual read/write routines in debugfs with the common >> simple attribute helpers. Doing this gets rid of repeated copy/pasting >> of copy_from_user and value

Re: [PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-11 Thread Daniel Vetter
On Sun, Mar 10, 2013 at 02:10:06PM -0700, Kees Cook wrote: > This replaces the manual read/write routines in debugfs with the common > simple attribute helpers. Doing this gets rid of repeated copy/pasting > of copy_from_user and value formatting code. > > Signed-off-by: Kees Cook > Cc: Daniel

Re: [PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-11 Thread Daniel Vetter
On Sun, Mar 10, 2013 at 02:10:06PM -0700, Kees Cook wrote: This replaces the manual read/write routines in debugfs with the common simple attribute helpers. Doing this gets rid of repeated copy/pasting of copy_from_user and value formatting code. Signed-off-by: Kees Cook

Re: [PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-11 Thread Kees Cook
On Mon, Mar 11, 2013 at 4:03 PM, Daniel Vetter dan...@ffwll.ch wrote: On Sun, Mar 10, 2013 at 02:10:06PM -0700, Kees Cook wrote: This replaces the manual read/write routines in debugfs with the common simple attribute helpers. Doing this gets rid of repeated copy/pasting of copy_from_user and

[PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-10 Thread Kees Cook
This replaces the manual read/write routines in debugfs with the common simple attribute helpers. Doing this gets rid of repeated copy/pasting of copy_from_user and value formatting code. Signed-off-by: Kees Cook Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_debugfs.c | 394

[PATCH] drm/i915: use simple attribute in debugfs routines

2013-03-10 Thread Kees Cook
This replaces the manual read/write routines in debugfs with the common simple attribute helpers. Doing this gets rid of repeated copy/pasting of copy_from_user and value formatting code. Signed-off-by: Kees Cook keesc...@chromium.org Cc: Daniel Vetter daniel.vet...@ffwll.ch ---