Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-22 Thread Rusty Russell
Kees Cook writes: > On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >> Oded Gabbay writes: >>> On 12/24/2014 01:01 AM, Rusty Russell wrote: Oded Gabbay writes: > I didn't say it doesn't always work. > The actual thing that doesn't work is the define symbol_get and only in a

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-22 Thread Rusty Russell
Kees Cook keesc...@chromium.org writes: On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Oded Gabbay oded.gab...@amd.com writes: On 12/24/2014 01:01 AM, Rusty Russell wrote: Oded Gabbay oded.gab...@amd.com writes: I didn't say it doesn't always work. The actual

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-16 Thread Oded Gabbay
On 01/16/2015 02:27 AM, Kees Cook wrote: > On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >> Oded Gabbay writes: >>> On 12/24/2014 01:01 AM, Rusty Russell wrote: Oded Gabbay writes: > I didn't say it doesn't always work. > The actual thing that doesn't work is the define

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-16 Thread Oded Gabbay
On 01/16/2015 02:27 AM, Kees Cook wrote: On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Oded Gabbay oded.gab...@amd.com writes: On 12/24/2014 01:01 AM, Rusty Russell wrote: Oded Gabbay oded.gab...@amd.com writes: I didn't say it doesn't always work. The actual

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-15 Thread Kees Cook
On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: > Oded Gabbay writes: >> On 12/24/2014 01:01 AM, Rusty Russell wrote: >>> Oded Gabbay writes: I didn't say it doesn't always work. The actual thing that doesn't work is the define symbol_get and only in a specific case of 32bit

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-15 Thread Kees Cook
On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Oded Gabbay oded.gab...@amd.com writes: On 12/24/2014 01:01 AM, Rusty Russell wrote: Oded Gabbay oded.gab...@amd.com writes: I didn't say it doesn't always work. The actual thing that doesn't work is the define

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-13 Thread Kees Cook
On Tue, Jan 6, 2015 at 2:58 PM, Rusty Russell wrote: > Kees Cook writes: >> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs >>> section for weak symbols. These should not be relocated if already 0. >> >> A few

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-13 Thread Kees Cook
On Tue, Jan 6, 2015 at 2:58 PM, Rusty Russell ru...@rustcorp.com.au wrote: Kees Cook keesc...@chromium.org writes: On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Kees, as far as I can tell you need another 0-terminated vmlinux.relocs section for weak symbols. These

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-11 Thread Oded Gabbay
On 01/07/2015 12:58 AM, Rusty Russell wrote: > Kees Cook writes: >> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs >>> section for weak symbols. These should not be relocated if already 0. >> >> A few questions:

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-11 Thread Oded Gabbay
On 01/07/2015 12:58 AM, Rusty Russell wrote: Kees Cook keesc...@chromium.org writes: On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Kees, as far as I can tell you need another 0-terminated vmlinux.relocs section for weak symbols. These should not be relocated if

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-06 Thread Rusty Russell
Kees Cook writes: > On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs >> section for weak symbols. These should not be relocated if already 0. > > A few questions: > > Why doesn't this break on 32-bit without kASLR?

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-06 Thread Kees Cook
On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: > Oded Gabbay writes: >> On 12/24/2014 01:01 AM, Rusty Russell wrote: >>> Oded Gabbay writes: I didn't say it doesn't always work. The actual thing that doesn't work is the define symbol_get and only in a specific case of 32bit

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-06 Thread Kees Cook
On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Oded Gabbay oded.gab...@amd.com writes: On 12/24/2014 01:01 AM, Rusty Russell wrote: Oded Gabbay oded.gab...@amd.com writes: I didn't say it doesn't always work. The actual thing that doesn't work is the define

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-06 Thread Rusty Russell
Kees Cook keesc...@chromium.org writes: On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Kees, as far as I can tell you need another 0-terminated vmlinux.relocs section for weak symbols. These should not be relocated if already 0. A few questions: Why doesn't this

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-04 Thread Rusty Russell
Oded Gabbay writes: > On 12/24/2014 01:01 AM, Rusty Russell wrote: >> Oded Gabbay writes: >>> I didn't say it doesn't always work. >>> The actual thing that doesn't work is the define symbol_get and only in a >>> specific case of 32bit kernel AND CONFIG_MODULES is unset AND >>>

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-04 Thread Rusty Russell
Oded Gabbay oded.gab...@amd.com writes: On 12/24/2014 01:01 AM, Rusty Russell wrote: Oded Gabbay oded.gab...@amd.com writes: I didn't say it doesn't always work. The actual thing that doesn't work is the define symbol_get and only in a specific case of 32bit kernel AND CONFIG_MODULES is unset

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-28 Thread Oded Gabbay
On 12/25/2014 02:31 PM, Christian König wrote: Am 22.12.2014 um 20:18 schrieb Oded Gabbay: On 12/22/2014 09:00 PM, Andi Kleen wrote: On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: On Mon, Dec 22, 2014 at 6:11 AM,

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-28 Thread Oded Gabbay
On 12/25/2014 02:31 PM, Christian König wrote: Am 22.12.2014 um 20:18 schrieb Oded Gabbay: On 12/22/2014 09:00 PM, Andi Kleen wrote: On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: On Mon, Dec 22, 2014 at 6:11 AM,

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-25 Thread Christian König
Am 22.12.2014 um 20:18 schrieb Oded Gabbay: On 12/22/2014 09:00 PM, Andi Kleen wrote: On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay wrote: amdkfd driver can be compiled

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-25 Thread Christian König
Am 22.12.2014 um 20:18 schrieb Oded Gabbay: On 12/22/2014 09:00 PM, Andi Kleen wrote: On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay oded.gab...@amd.com wrote: amdkfd

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-23 Thread Rusty Russell
Oded Gabbay writes: > I didn't say it doesn't always work. > The actual thing that doesn't work is the define symbol_get and only in a > specific case of 32bit kernel AND CONFIG_MODULES is unset AND > CONFIG_RANDOMIZE_BASE is set. > The define in that case is: > #define symbol_get(x) ({ extern

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-23 Thread Rusty Russell
Oded Gabbay oded.gab...@amd.com writes: I didn't say it doesn't always work. The actual thing that doesn't work is the define symbol_get and only in a specific case of 32bit kernel AND CONFIG_MODULES is unset AND CONFIG_RANDOMIZE_BASE is set. The define in that case is: #define symbol_get(x)

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Oded Gabbay
On 12/22/2014 09:00 PM, Andi Kleen wrote: > On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: >> On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: >>> On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay wrote: amdkfd driver can be compiled only in 64-bit kernel. Therefore,

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Andi Kleen
On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: > On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: > > On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay wrote: > > > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is > > > no > > > point in trying to

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Andi Kleen
On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: > On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay wrote: > > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no > > point in trying to initialize amdkfd in 32-bit kernel. > > > > In addition, in case of specific

Re: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Alex Deucher
On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay wrote: > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no > point in trying to initialize amdkfd in 32-bit kernel. > > In addition, in case of specific configuration of 32-bit kernel, no modules > and > random kernel base,

[PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Oded Gabbay
amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no point in trying to initialize amdkfd in 32-bit kernel. In addition, in case of specific configuration of 32-bit kernel, no modules and random kernel base, the symbol_request function doesn't work as expected - It doesn't

[PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Oded Gabbay
amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no point in trying to initialize amdkfd in 32-bit kernel. In addition, in case of specific configuration of 32-bit kernel, no modules and random kernel base, the symbol_request function doesn't work as expected - It doesn't

Re: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Alex Deucher
On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay oded.gab...@amd.com wrote: amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no point in trying to initialize amdkfd in 32-bit kernel. In addition, in case of specific configuration of 32-bit kernel, no modules and random

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Andi Kleen
On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay oded.gab...@amd.com wrote: amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no point in trying to initialize amdkfd in 32-bit kernel. In addition, in case of

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Andi Kleen
On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay oded.gab...@amd.com wrote: amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no point in trying

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2014-12-22 Thread Oded Gabbay
On 12/22/2014 09:00 PM, Andi Kleen wrote: On Mon, Dec 22, 2014 at 10:49:40AM -0800, Andi Kleen wrote: On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay oded.gab...@amd.com wrote: amdkfd driver can be compiled only in 64-bit kernel.