Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Daniel Vetter
On Mon, Mar 09, 2015 at 02:24:09PM +0530, Archit Taneja wrote: > > > On 03/09/2015 01:14 PM, Daniel Vetter wrote: > >On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: > >>On 03/05/2015 09:14 PM, Daniel Vetter wrote: > >>>On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: >

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Rob Clark
On Mon, Mar 9, 2015 at 4:54 AM, Archit Taneja wrote: > > > On 03/09/2015 01:14 PM, Daniel Vetter wrote: >> >> On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: >>> >>> On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote:

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Archit Taneja
On 03/09/2015 01:14 PM, Daniel Vetter wrote: On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja wrote: On 02/23/2015 09:09 PM,

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Daniel Vetter
On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: > On 03/05/2015 09:14 PM, Daniel Vetter wrote: > >On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: > >>On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja > >>wrote: > >>> > >>>On 02/23/2015 09:09 PM, Daniel Vetter wrote: >

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Rob Clark
On Mon, Mar 9, 2015 at 4:54 AM, Archit Taneja arch...@codeaurora.org wrote: On 03/09/2015 01:14 PM, Daniel Vetter wrote: On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote:

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Daniel Vetter
On Mon, Mar 09, 2015 at 02:24:09PM +0530, Archit Taneja wrote: On 03/09/2015 01:14 PM, Daniel Vetter wrote: On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: On Thu, Mar 5,

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Archit Taneja
On 03/09/2015 01:14 PM, Daniel Vetter wrote: On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja arch...@codeaurora.org wrote:

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-09 Thread Daniel Vetter
On Mon, Mar 09, 2015 at 11:27:06AM +0530, Archit Taneja wrote: On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja arch...@codeaurora.org wrote: On 02/23/2015 09:09 PM, Daniel Vetter wrote:

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-08 Thread Archit Taneja
On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja wrote: On 02/23/2015 09:09 PM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-08 Thread Archit Taneja
On 03/05/2015 09:14 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja arch...@codeaurora.org wrote: On 02/23/2015 09:09 PM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: On

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-05 Thread Daniel Vetter
On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: > On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja wrote: > > > > On 02/23/2015 09:09 PM, Daniel Vetter wrote: > >> > >> On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: > >>> > >>> On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-05 Thread Rob Clark
On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja wrote: > > On 02/23/2015 09:09 PM, Daniel Vetter wrote: >> >> On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: >>> >>> On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-05 Thread Archit Taneja
On 02/23/2015 09:09 PM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja wrote: The

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-05 Thread Daniel Vetter
On Thu, Mar 05, 2015 at 07:10:44AM -0500, Rob Clark wrote: On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja arch...@codeaurora.org wrote: On 02/23/2015 09:09 PM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-05 Thread Archit Taneja
On 02/23/2015 09:09 PM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-03-05 Thread Rob Clark
On Thu, Mar 5, 2015 at 5:06 AM, Archit Taneja arch...@codeaurora.org wrote: On 02/23/2015 09:09 PM, Daniel Vetter wrote: On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Feb 23, 2015 at 08:33:36AM

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Daniel Vetter
On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: > On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter wrote: > > On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: > >> On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja > >> wrote: > >> > The DRM_KMS_FB_HELPER config is selected only

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Rob Clark
On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter wrote: > On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: >> On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja >> wrote: >> > The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is >> > selected. The driver accesses

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Daniel Vetter
On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: > On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja wrote: > > The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is > > selected. The driver accesses drm_fb_helper_* functions even when legacy > > fbdev > > support is

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Rob Clark
On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja wrote: > The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is > selected. The driver accesses drm_fb_helper_* functions even when legacy fbdev > support is disabled in msm. Wrap around these functions with #ifdef checks to >

[PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Archit Taneja
The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is selected. The driver accesses drm_fb_helper_* functions even when legacy fbdev support is disabled in msm. Wrap around these functions with #ifdef checks to prevent build break. Signed-off-by: Archit Taneja ---

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Rob Clark
On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja arch...@codeaurora.org wrote: The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is selected. The driver accesses drm_fb_helper_* functions even when legacy fbdev support is disabled in msm. Wrap around these functions with

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Daniel Vetter
On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja arch...@codeaurora.org wrote: The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is selected. The driver accesses drm_fb_helper_* functions even when legacy fbdev

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Daniel Vetter
On Mon, Feb 23, 2015 at 10:03:21AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja arch...@codeaurora.org wrote: The DRM_KMS_FB_HELPER

Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Rob Clark
On Mon, Feb 23, 2015 at 9:09 AM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Feb 23, 2015 at 08:33:36AM -0500, Rob Clark wrote: On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja arch...@codeaurora.org wrote: The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is selected.

[PATCH] drm: msm: Fix build when legacy fbdev support isn't set

2015-02-23 Thread Archit Taneja
The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is selected. The driver accesses drm_fb_helper_* functions even when legacy fbdev support is disabled in msm. Wrap around these functions with #ifdef checks to prevent build break. Signed-off-by: Archit Taneja