Re: [PATCH] drm: remove unused function
Hi Sudip, On 14 May 2015 at 12:14, Sudip Mukherjee wrote: > this function was not used anywhere and was giving a build warning. Thanks for the patch, but this function is used in following patches that are in the process of being merged. This shouldn't have snuck in in the earlier patch; apologies. Cheers, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] drm: remove unused function
this function was not used anywhere and was giving a build warning. Signed-off-by: Sudip Mukherjee --- drivers/gpu/drm/drm_crtc.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 4059f06..6e60f71 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob) EXPORT_SYMBOL(drm_property_unreference_blob); /** - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held - * - * Drop a reference on a blob property. May free the object. This must be - * called with blob_lock held. - * - * @param dev Device the blob was created on - * @param blob Pointer to blob property - */ -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob) -{ - if (!blob) - return; - - DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(>refcount.refcount)); - - kref_put(>refcount, drm_property_free_blob); -} - -/** * drm_property_reference_blob - Take a reference on an existing property * * Take a new reference on an existing blob property. -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drm: remove unused function
Hi Sudip, On 14 May 2015 at 12:14, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: this function was not used anywhere and was giving a build warning. Thanks for the patch, but this function is used in following patches that are in the process of being merged. This shouldn't have snuck in in the earlier patch; apologies. Cheers, Daniel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] drm: remove unused function
this function was not used anywhere and was giving a build warning. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- drivers/gpu/drm/drm_crtc.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 4059f06..6e60f71 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob) EXPORT_SYMBOL(drm_property_unreference_blob); /** - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held - * - * Drop a reference on a blob property. May free the object. This must be - * called with blob_lock held. - * - * @param dev Device the blob was created on - * @param blob Pointer to blob property - */ -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob) -{ - if (!blob) - return; - - DRM_DEBUG(%p: blob ID: %d (%d)\n, blob, blob-base.id, atomic_read(blob-refcount.refcount)); - - kref_put(blob-refcount, drm_property_free_blob); -} - -/** * drm_property_reference_blob - Take a reference on an existing property * * Take a new reference on an existing blob property. -- 1.8.1.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/