Re: [PATCH] efi_64: Fix a missing-check bug in arch/x86/platform/efi/efi_64.c of Linux 5.1

2019-05-17 Thread Gen Zhang
On Fri, May 17, 2019 at 10:41:28AM +0200, Ard Biesheuvel wrote: > Returning an error here is not going to make much difference, given > that the caller of efi_call_phys_prolog() does not bother to check it, > and passes the result straight into efi_call_phys_epilog(), which > happily attempts to

[PATCH] efi_64: Fix a missing-check bug in arch/x86/platform/efi/efi_64.c of Linux 5.1

2019-05-17 Thread Gen Zhang
save_pgd is allocated by kmalloc_array. And it is dereferenced in the following codes. However, memory allocation functions such as kmalloc_array may fail. Dereferencing this save_pgd null pointer may cause the kernel go wrong. Thus we should check this allocation and add error handling code.