Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-23 Thread Will Deacon
On Sun, Dec 20, 2020 at 10:58:30AM +0100, Heiko Carstens wrote: > Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up > the 64 bit syscall instead of the compat variant in a couple of places. > > Cc: Willem de Bruijn > Cc: Al Viro > Cc: Arnd Bergmann > Cc: Matthew Wilcox

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Linus Torvalds
On Sun, Dec 20, 2020 at 10:22 AM Willem de Bruijn wrote: > > Slightly tangential, it's not immediately clear to me why in > arch/x86/entry/syscalls/syscall_32.tbl epoll_pwait does not need a > compat entry, unlike on other architectures and unlike signalfd. Hmm. Good question. That looks like a

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Linus Torvalds
On Sun, Dec 20, 2020 at 12:14 PM Arnd Bergmann wrote: > > The sigset_t argument is actually compatible between x86-32 and x86-64 Well, random high bits in size_t or the pointer value aren't. So it still looks a bit iffy to me. But it might end up working almost by accident. Linus

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Arnd Bergmann
On Sun, Dec 20, 2020 at 10:06 PM Linus Torvalds wrote: > > On Sun, Dec 20, 2020 at 12:14 PM Arnd Bergmann wrote: > > > > The sigset_t argument is actually compatible between x86-32 and x86-64 > > Well, random high bits in size_t or the pointer value aren't. So it > still looks a bit iffy to me.

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Arnd Bergmann
On Sun, Dec 20, 2020 at 7:51 PM Linus Torvalds wrote: > > On Sun, Dec 20, 2020 at 10:22 AM Willem de Bruijn > wrote: > > > > Slightly tangential, it's not immediately clear to me why in > > arch/x86/entry/syscalls/syscall_32.tbl epoll_pwait does not need a > > compat entry, unlike on other

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Willem de Bruijn
On Sun, Dec 20, 2020 at 6:43 AM Arnd Bergmann wrote: > > On Sun, Dec 20, 2020 at 11:00 AM Heiko Carstens wrote: > > > > Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up > > the 64 bit syscall instead of the compat variant in a couple of places. > > > > Cc: Willem de Bruijn >

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Arnd Bergmann
On Sun, Dec 20, 2020 at 11:00 AM Heiko Carstens wrote: > > Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up > the 64 bit syscall instead of the compat variant in a couple of places. > > Cc: Willem de Bruijn > Cc: Al Viro > Cc: Arnd Bergmann > Cc: Matthew Wilcox (Oracle) >

[PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Heiko Carstens
Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up the 64 bit syscall instead of the compat variant in a couple of places. Cc: Willem de Bruijn Cc: Al Viro Cc: Arnd Bergmann Cc: Matthew Wilcox (Oracle) Cc: Catalin Marinas Cc: Will Deacon Cc: Thomas Bogendoerfer Cc: Vasily