Re: [PATCH] ethtool: fix a potential missing-check bug

2018-04-30 Thread Shannon Nelson
On 4/29/2018 6:31 PM, Wenwen Wang wrote: In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has

Re: [PATCH] ethtool: fix a potential missing-check bug

2018-04-30 Thread Shannon Nelson
On 4/29/2018 6:31 PM, Wenwen Wang wrote: In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has

Re: [PATCH] ethtool: fix a potential missing-check bug

2018-04-30 Thread Edward Cree
On 30/04/18 02:31, Wenwen Wang wrote: > In ethtool_get_rxnfc(), the object "info" is firstly copied from > user-space. If the FLOW_RSS flag is set in the member field flow_type of > "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from > user-space because FLOW_RSS is newer and has

Re: [PATCH] ethtool: fix a potential missing-check bug

2018-04-30 Thread Edward Cree
On 30/04/18 02:31, Wenwen Wang wrote: > In ethtool_get_rxnfc(), the object "info" is firstly copied from > user-space. If the FLOW_RSS flag is set in the member field flow_type of > "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from > user-space because FLOW_RSS is newer and has

[PATCH] ethtool: fix a potential missing-check bug

2018-04-29 Thread Wenwen Wang
In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has new definition, as mentioned in the comment.

[PATCH] ethtool: fix a potential missing-check bug

2018-04-29 Thread Wenwen Wang
In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has new definition, as mentioned in the comment.