RE: [PATCH] exfat: fix pointer error checking

[Namjae Jeon]

> Fix missing result check of exfat_build_inode().
> And use PTR_ERR_OR_ZERO instead of PTR_ERR.
> 
> Signed-off-by: Tetsuhiro Kohada 
Pushed it to exfat #dev.
Thanks for your patch!

[PATCH] exfat: fix pointer error checking

[Tetsuhiro Kohada]

Fix missing result check of exfat_build_inode().
And use PTR_ERR_OR_ZERO instead of PTR_ERR.

Signed-off-by: Tetsuhiro Kohada 
---
 fs/exfat/namei.c | 13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
index 2aff6605fecc..0b12033e1577 100644
--- a/fs/exfat/namei.c
+++ b/fs/exfat/namei.c
@@ -578,7 +578,8 @@ static int exfat_create(struct inode *dir, struct dentry 
*dentry, umode_t mode,
 
i_pos = exfat_make_i_pos();
inode = exfat_build_inode(sb, , i_pos);
-   if (IS_ERR(inode))
+   err = PTR_ERR_OR_ZERO(inode);
+   if (err)
goto unlock;
 
inode_inc_iversion(inode);
@@ -745,10 +746,9 @@ static struct dentry *exfat_lookup(struct inode *dir, 
struct dentry *dentry,
 
i_pos = exfat_make_i_pos();
inode = exfat_build_inode(sb, , i_pos);
-   if (IS_ERR(inode)) {
-   err = PTR_ERR(inode);
+   err = PTR_ERR_OR_ZERO(inode);
+   if (err)
goto unlock;
-   }
 
i_mode = inode->i_mode;
alias = d_find_alias(inode);
@@ -890,10 +890,9 @@ static int exfat_mkdir(struct inode *dir, struct dentry 
*dentry, umode_t mode)
 
i_pos = exfat_make_i_pos();
inode = exfat_build_inode(sb, , i_pos);
-   if (IS_ERR(inode)) {
-   err = PTR_ERR(inode);
+   err = PTR_ERR_OR_ZERO(inode);
+   if (err)
goto unlock;
-   }
 
inode_inc_iversion(inode);
inode->i_mtime = inode->i_atime = inode->i_ctime =
-- 
2.25.1