Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

2018-08-05 Thread Theodore Y. Ts'o
On Sun, Aug 05, 2018 at 08:59:33PM +0800, zhong jiang wrote: > I create the diff in this patch again ,but get the same result . > the git version is git version 1.7.12.4 but I create the diff in > git version 1.8.3.1. It shows the correct function name. Ah, OK, so it was a git bug. Whew! Glad

Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

2018-08-05 Thread zhong jiang
On 2018/8/5 5:24, Theodore Y. Ts'o wrote: > On Sat, Aug 04, 2018 at 07:04:56PM +0800, zhong jiang wrote: >> The err is not used after initalization. So just remove the variable. >> >> Signed-off-by: zhong jiang > I'll apply this patch, but how did you generate the diff? The > function name here i

Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

2018-08-04 Thread Theodore Y. Ts'o
On Sat, Aug 04, 2018 at 07:04:56PM +0800, zhong jiang wrote: > The err is not used after initalization. So just remove the variable. > > Signed-off-by: zhong jiang I'll apply this patch, but how did you generate the diff? The function name here is all wrong: > diff --git a/fs/ext4/mballoc.c b/

[PATCH] ext4/mballoc: Remove unneeded variable "err"

2018-08-04 Thread zhong jiang
The err is not used after initalization. So just remove the variable. Signed-off-by: zhong jiang --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 8b24d3d..e29fce2 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/m