Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-29 Thread Theodore Ts'o
On Thu, Sep 22, 2016 at 08:50:54AM +0200, Richard Weinberger wrote: > ...otherwise an user can enable encryption for certain files even > when the filesystem is unable to support it. > Such a case would be a filesystem created by mkfs.ext4's default > settings, 1KiB block size. Ext4 supports

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-29 Thread Theodore Ts'o
On Thu, Sep 22, 2016 at 08:50:54AM +0200, Richard Weinberger wrote: > ...otherwise an user can enable encryption for certain files even > when the filesystem is unable to support it. > Such a case would be a filesystem created by mkfs.ext4's default > settings, 1KiB block size. Ext4 supports

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-23 Thread Eric Biggers
On Thu, Sep 22, 2016 at 06:38:03PM -0400, Theodore Ts'o wrote: > > I think it's fine to fix it now in upstream. It might cause some > problems for Cyanogen developers if they want to try to use an > upstream kernel and also enable the ext4 encryption feature, but the > fix to make_ext4fs isn't

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-23 Thread Eric Biggers
On Thu, Sep 22, 2016 at 06:38:03PM -0400, Theodore Ts'o wrote: > > I think it's fine to fix it now in upstream. It might cause some > problems for Cyanogen developers if they want to try to use an > upstream kernel and also enable the ext4 encryption feature, but the > fix to make_ext4fs isn't

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Theodore Ts'o
On Thu, Sep 22, 2016 at 12:49:31PM -0700, Eric Biggers wrote: > > Ted had actually pointed out that the reason this hasn't already been fixed is > that some users, e.g. Android, do not set the feature flag but still expect > the > filesystem encryption code to work. Maybe he can chime in with

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Theodore Ts'o
On Thu, Sep 22, 2016 at 12:49:31PM -0700, Eric Biggers wrote: > > Ted had actually pointed out that the reason this hasn't already been fixed is > that some users, e.g. Android, do not set the feature flag but still expect > the > filesystem encryption code to work. Maybe he can chime in with

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Richard Weinberger
Eric, On 22.09.2016 21:49, Eric Biggers wrote: > On Thu, Sep 22, 2016 at 08:50:54AM +0200, Richard Weinberger wrote: >> ...otherwise an user can enable encryption for certain files even >> when the filesystem is unable to support it. >> Such a case would be a filesystem created by mkfs.ext4's

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Richard Weinberger
Eric, On 22.09.2016 21:49, Eric Biggers wrote: > On Thu, Sep 22, 2016 at 08:50:54AM +0200, Richard Weinberger wrote: >> ...otherwise an user can enable encryption for certain files even >> when the filesystem is unable to support it. >> Such a case would be a filesystem created by mkfs.ext4's

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Eric Biggers
On Thu, Sep 22, 2016 at 08:50:54AM +0200, Richard Weinberger wrote: > ...otherwise an user can enable encryption for certain files even > when the filesystem is unable to support it. > Such a case would be a filesystem created by mkfs.ext4's default > settings, 1KiB block size. Ext4 supports

Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Eric Biggers
On Thu, Sep 22, 2016 at 08:50:54AM +0200, Richard Weinberger wrote: > ...otherwise an user can enable encryption for certain files even > when the filesystem is unable to support it. > Such a case would be a filesystem created by mkfs.ext4's default > settings, 1KiB block size. Ext4 supports

[PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Richard Weinberger
...otherwise an user can enable encryption for certain files even when the filesystem is unable to support it. Such a case would be a filesystem created by mkfs.ext4's default settings, 1KiB block size. Ext4 supports encyption only when block size is equal to PAGE_SIZE. But this constraint is only

[PATCH] ext4: Check for encryption feature before fscrypt_process_policy()

2016-09-22 Thread Richard Weinberger
...otherwise an user can enable encryption for certain files even when the filesystem is unable to support it. Such a case would be a filesystem created by mkfs.ext4's default settings, 1KiB block size. Ext4 supports encyption only when block size is equal to PAGE_SIZE. But this constraint is only