On Wed, Aug 01, 2018 at 09:13:19AM -0700, Matthew Wilcox wrote:
> On Wed, Aug 01, 2018 at 12:06:18PM -0400, Theodore Y. Ts'o wrote:
> > On Wed, Aug 01, 2018 at 10:38:30AM -0400, Theodore Y. Ts'o wrote:
> > > I'm going to drop the whole ext4 changes for vm_fault_t for this
> > > cycle, and I'll let
On Wed, Aug 01, 2018 at 09:13:19AM -0700, Matthew Wilcox wrote:
> On Wed, Aug 01, 2018 at 12:06:18PM -0400, Theodore Y. Ts'o wrote:
> > On Wed, Aug 01, 2018 at 10:38:30AM -0400, Theodore Y. Ts'o wrote:
> > > I'm going to drop the whole ext4 changes for vm_fault_t for this
> > > cycle, and I'll let
On Wed, Aug 01, 2018 at 12:06:18PM -0400, Theodore Y. Ts'o wrote:
> On Wed, Aug 01, 2018 at 10:38:30AM -0400, Theodore Y. Ts'o wrote:
> > I'm going to drop the whole ext4 changes for vm_fault_t for this
> > cycle, and I'll let you try to fix it up properly for the next cycle.
>
> Here's the fixed
On Wed, Aug 01, 2018 at 12:06:18PM -0400, Theodore Y. Ts'o wrote:
> On Wed, Aug 01, 2018 at 10:38:30AM -0400, Theodore Y. Ts'o wrote:
> > I'm going to drop the whole ext4 changes for vm_fault_t for this
> > cycle, and I'll let you try to fix it up properly for the next cycle.
>
> Here's the fixed
On Wed, Aug 01, 2018 at 10:38:30AM -0400, Theodore Y. Ts'o wrote:
> I'm going to drop the whole ext4 changes for vm_fault_t for this
> cycle, and I'll let you try to fix it up properly for the next cycle.
Here's the fixed up commit that I'm going to drop since you plan to be
making changes in
On Wed, Aug 01, 2018 at 10:38:30AM -0400, Theodore Y. Ts'o wrote:
> I'm going to drop the whole ext4 changes for vm_fault_t for this
> cycle, and I'll let you try to fix it up properly for the next cycle.
Here's the fixed up commit that I'm going to drop since you plan to be
making changes in
On Wed, Aug 01, 2018 at 06:56:39PM +0530, Souptick Joarder wrote:
> As caller of block_page_mkwrite() are -
> fs/ext4/inode.c
> fs/nilfs2/file.c
>
> I will merge both changes in a single patch and send it.
Note that it's *important* for ext4 that we know what kind of error
was returned by the
On Wed, Aug 01, 2018 at 06:56:39PM +0530, Souptick Joarder wrote:
> As caller of block_page_mkwrite() are -
> fs/ext4/inode.c
> fs/nilfs2/file.c
>
> I will merge both changes in a single patch and send it.
Note that it's *important* for ext4 that we know what kind of error
was returned by the
On Wed, Aug 1, 2018 at 6:43 PM, Matthew Wilcox wrote:
> On Wed, Aug 01, 2018 at 06:34:45PM +0530, Souptick Joarder wrote:
>> > The fact that ext4_page_mkwrite() returns a vm_fault_t, while
>> > block_page_mkwrite() returns an int which then has to get translated
>> > into a vm_fault_t via
On Wed, Aug 1, 2018 at 6:43 PM, Matthew Wilcox wrote:
> On Wed, Aug 01, 2018 at 06:34:45PM +0530, Souptick Joarder wrote:
>> > The fact that ext4_page_mkwrite() returns a vm_fault_t, while
>> > block_page_mkwrite() returns an int which then has to get translated
>> > into a vm_fault_t via
On Wed, Aug 01, 2018 at 06:34:45PM +0530, Souptick Joarder wrote:
> > The fact that ext4_page_mkwrite() returns a vm_fault_t, while
> > block_page_mkwrite() returns an int which then has to get translated
> > into a vm_fault_t via block_page_mkwrite_return() is I suspect going
> > to confuse an
On Wed, Aug 01, 2018 at 06:34:45PM +0530, Souptick Joarder wrote:
> > The fact that ext4_page_mkwrite() returns a vm_fault_t, while
> > block_page_mkwrite() returns an int which then has to get translated
> > into a vm_fault_t via block_page_mkwrite_return() is I suspect going
> > to confuse an
On Wed, Aug 1, 2018 at 6:34 PM, Souptick Joarder wrote:
> On Wed, Aug 1, 2018 at 6:25 PM, Theodore Y. Ts'o wrote:
>> On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote:
>>> Use new return type vm_fault_t for ext4_page_mkwrite
>>> handler and block_page_mkwrite_return.
>>>
>>>
On Wed, Aug 1, 2018 at 6:34 PM, Souptick Joarder wrote:
> On Wed, Aug 1, 2018 at 6:25 PM, Theodore Y. Ts'o wrote:
>> On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote:
>>> Use new return type vm_fault_t for ext4_page_mkwrite
>>> handler and block_page_mkwrite_return.
>>>
>>>
On Wed, Aug 1, 2018 at 6:25 PM, Theodore Y. Ts'o wrote:
> On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote:
>> Use new return type vm_fault_t for ext4_page_mkwrite
>> handler and block_page_mkwrite_return.
>>
>> Signed-off-by: Souptick Joarder
>
> FYI, this patch was very sloppy,
On Wed, Aug 1, 2018 at 6:25 PM, Theodore Y. Ts'o wrote:
> On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote:
>> Use new return type vm_fault_t for ext4_page_mkwrite
>> handler and block_page_mkwrite_return.
>>
>> Signed-off-by: Souptick Joarder
>
> FYI, this patch was very sloppy,
On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for ext4_page_mkwrite
> handler and block_page_mkwrite_return.
>
> Signed-off-by: Souptick Joarder
FYI, this patch was very sloppy, and didn't do the right thing. That's
because of how you messed
On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for ext4_page_mkwrite
> handler and block_page_mkwrite_return.
>
> Signed-off-by: Souptick Joarder
FYI, this patch was very sloppy, and didn't do the right thing. That's
because of how you messed
On Sat, Jul 28, 2018 at 2:20 PM, Souptick Joarder wrote:
> Use new return type vm_fault_t for ext4_page_mkwrite
> handler and block_page_mkwrite_return.
>
> Signed-off-by: Souptick Joarder
As part of commit 2fae376c0a16db42eb438 in linux-next tree,
this conversion was missed. Sorry about it.
>
On Sat, Jul 28, 2018 at 2:20 PM, Souptick Joarder wrote:
> Use new return type vm_fault_t for ext4_page_mkwrite
> handler and block_page_mkwrite_return.
>
> Signed-off-by: Souptick Joarder
As part of commit 2fae376c0a16db42eb438 in linux-next tree,
this conversion was missed. Sorry about it.
>
Use new return type vm_fault_t for ext4_page_mkwrite
handler and block_page_mkwrite_return.
Signed-off-by: Souptick Joarder
---
fs/ext4/ext4.h | 2 +-
fs/ext4/inode.c | 20 ++--
include/linux/buffer_head.h | 3 ++-
3 files changed, 13 insertions(+), 12
Use new return type vm_fault_t for ext4_page_mkwrite
handler and block_page_mkwrite_return.
Signed-off-by: Souptick Joarder
---
fs/ext4/ext4.h | 2 +-
fs/ext4/inode.c | 20 ++--
include/linux/buffer_head.h | 3 ++-
3 files changed, 13 insertions(+), 12
22 matches
Mail list logo
