Re: [PATCH] ext4: Delete redundant uptodate check for buffer

[Theodore Ts'o]

On Thu, Apr 01, 2021 at 04:50:01PM +0530, Ritesh Harjani wrote:
> On 21/04/01 03:03PM, Shaokun Zhang wrote:
> > From: Yang Guo 
> >
> > The buffer uptodate state has been checked in function set_buffer_uptodate,
> > there is no need use buffer_uptodate before calling set_buffer_uptodate and
> > delete it.
> >
> > Cc: "Theodore Ts'o" 
> > Cc: Andreas Dilger 
> > Signed-off-by: Yang Guo 
> > Signed-off-by: Shaokun Zhang 
> > ---
> >  fs/ext4/inode.c | 6 ++
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Thanks for the patch. Changes looks good and trivial.
> 
> Feel free to add -
> Reviewed-by: Ritesh Harjani 

Thanks, applied.

- Ted

Re: [PATCH] ext4: Delete redundant uptodate check for buffer

[Ritesh Harjani]

On 21/04/01 03:03PM, Shaokun Zhang wrote:
> From: Yang Guo 
>
> The buffer uptodate state has been checked in function set_buffer_uptodate,
> there is no need use buffer_uptodate before calling set_buffer_uptodate and
> delete it.
>
> Cc: "Theodore Ts'o" 
> Cc: Andreas Dilger 
> Signed-off-by: Yang Guo 
> Signed-off-by: Shaokun Zhang 
> ---
>  fs/ext4/inode.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)

Thanks for the patch. Changes looks good and trivial.

Feel free to add -
Reviewed-by: Ritesh Harjani 

[PATCH] ext4: Delete redundant uptodate check for buffer

[Shaokun Zhang]

From: Yang Guo 

The buffer uptodate state has been checked in function set_buffer_uptodate,
there is no need use buffer_uptodate before calling set_buffer_uptodate and
delete it.

Cc: "Theodore Ts'o" 
Cc: Andreas Dilger 
Signed-off-by: Yang Guo 
Signed-off-by: Shaokun Zhang 
---
 fs/ext4/inode.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 0948a43f1b3d..32fa3ad38797 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -1066,8 +1066,7 @@ static int ext4_block_write_begin(struct page *page, 
loff_t pos, unsigned len,
block_end = block_start + blocksize;
if (block_end <= from || block_start >= to) {
if (PageUptodate(page)) {
-   if (!buffer_uptodate(bh))
-   set_buffer_uptodate(bh);
+   set_buffer_uptodate(bh);
}
continue;
}
@@ -1092,8 +1091,7 @@ static int ext4_block_write_begin(struct page *page, 
loff_t pos, unsigned len,
}
}
if (PageUptodate(page)) {
-   if (!buffer_uptodate(bh))
-   set_buffer_uptodate(bh);
+   set_buffer_uptodate(bh);
continue;
}
if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
-- 
2.7.4