Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 02:12:44PM -0700, Andreas Dilger wrote: > > > On Feb 3, 2016, at 6:19 AM, Huaitong Han wrote: > > > > This patch adds a line break for proc mb_groups display. > > > > Signed-off-by: Huaitong Han > > Reviewed-by: Andreas Dilger Thanks, applied.

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 02:12:44PM -0700, Andreas Dilger wrote: > > > On Feb 3, 2016, at 6:19 AM, Huaitong Han wrote: > > > > This patch adds a line break for proc mb_groups display. > > > > Signed-off-by: Huaitong Han > > Reviewed-by: Andreas

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, 2016-02-03 at 14:12 -0700, Andreas Dilger wrote: > I think it makes sense to accept the patch, since I doubt any scripts > will be broken, and it is the "right thing to do" rather than > perpetuate a bug. Perhaps it also would make sense to add some text to the commit log about this.

Re: [PATCH] ext4: add a line break for proc mb_groups display

> On Feb 3, 2016, at 6:19 AM, Huaitong Han wrote: > > This patch adds a line break for proc mb_groups display. > > Signed-off-by: Huaitong Han Reviewed-by: Andreas Dilger > --- > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Feb 3, 2016, at 1:07 PM, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 11:38:33AM -0800, Joe Perches wrote: >> On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote: >>> On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: On Wed, 2016-02-03 at 10:13 -0800, Darrick J.

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 11:38:33AM -0800, Joe Perches wrote: > On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > > > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > > > On Wed, Feb 03, 2016 at 09:19:06PM

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote: > On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > > > This patch adds a line break for proc

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > > This patch adds a line break for proc mb_groups display. > > Using 2 lines for output might break any

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > This patch adds a line break for proc mb_groups display. Using 2 lines for output might break any existing users. Are there any? > > > > Signed-off-by: Huaitong Han >

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > This patch adds a line break for proc mb_groups display. > > Signed-off-by: Huaitong Han > --- > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c >

[PATCH] ext4: add a line break for proc mb_groups display

This patch adds a line break for proc mb_groups display. Signed-off-by: Huaitong Han --- fs/ext4/mballoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 61eaf74..4424b7b 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@

[PATCH] ext4: add a line break for proc mb_groups display

This patch adds a line break for proc mb_groups display. Signed-off-by: Huaitong Han --- fs/ext4/mballoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 61eaf74..4424b7b 100644 --- a/fs/ext4/mballoc.c +++

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Feb 3, 2016, at 1:07 PM, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 11:38:33AM -0800, Joe Perches wrote: >> On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote: >>> On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: On Wed, 2016-02-03 at

Re: [PATCH] ext4: add a line break for proc mb_groups display

> On Feb 3, 2016, at 6:19 AM, Huaitong Han wrote: > > This patch adds a line break for proc mb_groups display. > > Signed-off-by: Huaitong Han Reviewed-by: Andreas Dilger > --- > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, 2016-02-03 at 14:12 -0700, Andreas Dilger wrote: > I think it makes sense to accept the patch, since I doubt any scripts > will be broken, and it is the "right thing to do" rather than > perpetuate a bug. Perhaps it also would make sense to add some text to the commit log about this.

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > > This patch adds a line break for proc mb_groups display. > > Using 2 lines for output might break any

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote: > On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > > > This patch adds a line break for proc

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > This patch adds a line break for proc mb_groups display. > > Signed-off-by: Huaitong Han > --- > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > This patch adds a line break for proc mb_groups display. Using 2 lines for output might break any existing users. Are there any? > > > > Signed-off-by: Huaitong Han

Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, Feb 03, 2016 at 11:38:33AM -0800, Joe Perches wrote: > On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > > > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > > > On Wed, Feb 03, 2016 at 09:19:06PM