Re: [PATCH] ext4: fix bh leak on error paths in ext4_rename() and ext4_cross_rename()

2015-04-02 Thread Theodore Ts'o
On Tue, Mar 03, 2015 at 02:17:19PM +0300, Konstantin Khlebnikov wrote: > Release references to buffer-heads if ext4_journal_start() fails. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 5b61de757535 ("ext4: start handle at least possible moment when > renaming files") Thanks, applied.

Re: [PATCH] ext4: fix bh leak on error paths in ext4_rename() and ext4_cross_rename()

2015-04-02 Thread Theodore Ts'o
On Tue, Mar 03, 2015 at 02:17:19PM +0300, Konstantin Khlebnikov wrote: Release references to buffer-heads if ext4_journal_start() fails. Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru Fixes: 5b61de757535 (ext4: start handle at least possible moment when renaming files)

Re: [PATCH] ext4: fix bh leak on error paths in ext4_rename() and ext4_cross_rename()

2015-03-04 Thread Jan Kara
On Tue 03-03-15 14:17:19, Konstantin Khlebnikov wrote: > Release references to buffer-heads if ext4_journal_start() fails. Looks good. You can add: Reviewed-by: Jan Kara Honza > > Signed-off-by: Konstantin Khlebnikov > Fixes:

Re: [PATCH] ext4: fix bh leak on error paths in ext4_rename() and ext4_cross_rename()

2015-03-04 Thread Jan Kara
On Tue 03-03-15 14:17:19, Konstantin Khlebnikov wrote: Release references to buffer-heads if ext4_journal_start() fails. Looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz Honza Signed-off-by: Konstantin Khlebnikov

[PATCH] ext4: fix bh leak on error paths in ext4_rename() and ext4_cross_rename()

2015-03-03 Thread Konstantin Khlebnikov
Release references to buffer-heads if ext4_journal_start() fails. Signed-off-by: Konstantin Khlebnikov Fixes: 5b61de757535 ("ext4: start handle at least possible moment when renaming files") --- fs/ext4/namei.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-)

[PATCH] ext4: fix bh leak on error paths in ext4_rename() and ext4_cross_rename()

2015-03-03 Thread Konstantin Khlebnikov
Release references to buffer-heads if ext4_journal_start() fails. Signed-off-by: Konstantin Khlebnikov khlebni...@yandex-team.ru Fixes: 5b61de757535 (ext4: start handle at least possible moment when renaming files) --- fs/ext4/namei.c | 21 +++-- 1 file changed, 15