Re: [PATCH] ext4: fix possible use after free in ext4_quota_enable

2018-12-03 Thread Theodore Y. Ts'o
On Tue, Nov 27, 2018 at 10:14:53AM +0100, Jan Kara wrote: > On Mon 26-11-18 11:21:06, Pan Bian wrote: > > The function frees qf_inode via iput but then pass qf_inode to > > lockdep_set_quota_inode on the failure path. This may result in a > > use-after-free bug. The patch frees df_inode only when

Re: [PATCH] ext4: fix possible use after free in ext4_quota_enable

2018-12-03 Thread Theodore Y. Ts'o
On Tue, Nov 27, 2018 at 10:14:53AM +0100, Jan Kara wrote: > On Mon 26-11-18 11:21:06, Pan Bian wrote: > > The function frees qf_inode via iput but then pass qf_inode to > > lockdep_set_quota_inode on the failure path. This may result in a > > use-after-free bug. The patch frees df_inode only when

Re: [PATCH] ext4: fix possible use after free in ext4_quota_enable

2018-11-27 Thread Jan Kara
On Mon 26-11-18 11:21:06, Pan Bian wrote: > The function frees qf_inode via iput but then pass qf_inode to > lockdep_set_quota_inode on the failure path. This may result in a > use-after-free bug. The patch frees df_inode only when it is never used. > > Signed-off-by: Pan Bian > Fixes:

Re: [PATCH] ext4: fix possible use after free in ext4_quota_enable

2018-11-27 Thread Jan Kara
On Mon 26-11-18 11:21:06, Pan Bian wrote: > The function frees qf_inode via iput but then pass qf_inode to > lockdep_set_quota_inode on the failure path. This may result in a > use-after-free bug. The patch frees df_inode only when it is never used. > > Signed-off-by: Pan Bian > Fixes:

[PATCH] ext4: fix possible use after free in ext4_quota_enable

2018-11-25 Thread Pan Bian
The function frees qf_inode via iput but then pass qf_inode to lockdep_set_quota_inode on the failure path. This may result in a use-after-free bug. The patch frees df_inode only when it is never used. Signed-off-by: Pan Bian Fixes: daf647d2dd5("ext4: add lockdep annotations for i_data_sem") ---

[PATCH] ext4: fix possible use after free in ext4_quota_enable

2018-11-25 Thread Pan Bian
The function frees qf_inode via iput but then pass qf_inode to lockdep_set_quota_inode on the failure path. This may result in a use-after-free bug. The patch frees df_inode only when it is never used. Signed-off-by: Pan Bian Fixes: daf647d2dd5("ext4: add lockdep annotations for i_data_sem") ---