Re: [PATCH] ext4: prefer strlcpy to strncpy

2018-05-29 Thread Theodore Y. Ts'o
On Mon, May 28, 2018 at 11:21:53PM -0700, Nick Desaulniers wrote: > Fixes a stringop-truncation warning from gcc-8. > > Signed-off-by: Nick Desaulniers I'll note that the ext4 superblock fields are *not* guaranteed to be NULL terminated. Code that references them must, and do, deal with this ap

Re: [PATCH] ext4: prefer strlcpy to strncpy

2018-05-29 Thread Nick Desaulniers
On Mon, May 28, 2018 at 11:21 PM, Nick Desaulniers wrote: > Fixes a stringop-truncation warning from gcc-8. > > Signed-off-by: Nick Desaulniers > --- > fs/ext4/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index eb104e8..

[PATCH] ext4: prefer strlcpy to strncpy

2018-05-28 Thread Nick Desaulniers
Fixes a stringop-truncation warning from gcc-8. Signed-off-by: Nick Desaulniers --- fs/ext4/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index eb104e8..d47c85f 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -323,11 +323,