Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-10 Thread Jaegeuk Kim
On 10/09, Chao Yu wrote: > On 2017/10/8 3:30, Joe Perches wrote: > > On Sat, 2017-10-07 at 23:33 +0900, Ju Hyung Park wrote: > >> Isn't this bogus? > >> > >> "bool" type in Linux kernel is a typedef to "_Bool" > >> and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. > > > >

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-10 Thread Jaegeuk Kim
On 10/09, Chao Yu wrote: > On 2017/10/8 3:30, Joe Perches wrote: > > On Sat, 2017-10-07 at 23:33 +0900, Ju Hyung Park wrote: > >> Isn't this bogus? > >> > >> "bool" type in Linux kernel is a typedef to "_Bool" > >> and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. > > > >

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-08 Thread Chao Yu
On 2017/10/8 3:30, Joe Perches wrote: > On Sat, 2017-10-07 at 23:33 +0900, Ju Hyung Park wrote: >> Isn't this bogus? >> >> "bool" type in Linux kernel is a typedef to "_Bool" >> and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. > > Bogus? Well, not really. It's just a

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-08 Thread Chao Yu
On 2017/10/8 3:30, Joe Perches wrote: > On Sat, 2017-10-07 at 23:33 +0900, Ju Hyung Park wrote: >> Isn't this bogus? >> >> "bool" type in Linux kernel is a typedef to "_Bool" >> and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. > > Bogus? Well, not really. It's just a

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-07 Thread Joe Perches
On Sat, 2017-10-07 at 23:33 +0900, Ju Hyung Park wrote: > Isn't this bogus? > > "bool" type in Linux kernel is a typedef to "_Bool" > and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. Bogus? Well, not really. It's just a neatening and it's identical object code. The idea

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-07 Thread Joe Perches
On Sat, 2017-10-07 at 23:33 +0900, Ju Hyung Park wrote: > Isn't this bogus? > > "bool" type in Linux kernel is a typedef to "_Bool" > and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. Bogus? Well, not really. It's just a neatening and it's identical object code. The idea

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-07 Thread Ju Hyung Park
Isn't this bogus? "bool" type in Linux kernel is a typedef to "_Bool" and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. On Sat, Oct 7, 2017 at 11:02 PM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need >

Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison

2017-10-07 Thread Ju Hyung Park
Isn't this bogus? "bool" type in Linux kernel is a typedef to "_Bool" and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. On Sat, Oct 7, 2017 at 11:02 PM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > >

[PATCH] f2fs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/f2fs/data.c b/fs/f2fs/data.c --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -419,7 +419,7 @@ next: bio_page = fio->encrypted_page ?

[PATCH] f2fs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/f2fs/data.c b/fs/f2fs/data.c --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -419,7 +419,7 @@ next: bio_page = fio->encrypted_page ? fio->encrypted_page :