Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-31 Thread Gu Zheng
On 07/31/2013 06:06 PM, Jaegeuk Kim wrote: > 2013-07-31 (수), 09:59 +0800, Gu Zheng: >> Hi Kim, >> >> On 07/30/2013 08:29 PM, Jaegeuk Kim wrote: >> >>> Hi Gu, >>> >>> The original read flow was to avoid redandunt lock/unlock_page() calls. >> >> Right, this can gain better read performance. But is

Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-31 Thread Jaegeuk Kim
2013-07-31 (수), 09:59 +0800, Gu Zheng: > Hi Kim, > > On 07/30/2013 08:29 PM, Jaegeuk Kim wrote: > > > Hi Gu, > > > > The original read flow was to avoid redandunt lock/unlock_page() calls. > > Right, this can gain better read performance. But is the wait step after > submitting bio with

Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-31 Thread Jaegeuk Kim
2013-07-31 (수), 09:59 +0800, Gu Zheng: Hi Kim, On 07/30/2013 08:29 PM, Jaegeuk Kim wrote: Hi Gu, The original read flow was to avoid redandunt lock/unlock_page() calls. Right, this can gain better read performance. But is the wait step after submitting bio with READ_SYNC needless

Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-31 Thread Gu Zheng
On 07/31/2013 06:06 PM, Jaegeuk Kim wrote: 2013-07-31 (수), 09:59 +0800, Gu Zheng: Hi Kim, On 07/30/2013 08:29 PM, Jaegeuk Kim wrote: Hi Gu, The original read flow was to avoid redandunt lock/unlock_page() calls. Right, this can gain better read performance. But is the wait step after

Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-30 Thread Gu Zheng
Hi Kim, On 07/30/2013 08:29 PM, Jaegeuk Kim wrote: > Hi Gu, > > The original read flow was to avoid redandunt lock/unlock_page() calls. Right, this can gain better read performance. But is the wait step after submitting bio with READ_SYNC needless too? > And we should not wait for

Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-30 Thread Jaegeuk Kim
Hi Gu, The original read flow was to avoid redandunt lock/unlock_page() calls. And we should not wait for WRITE_SYNC, since it is just for write priority, not for synchronization of the file system. Thanks, 2013-07-30 (화), 18:06 +0800, Gu Zheng: > When we submit bio with READ_SYNC or WRITE_SYNC,

[PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-30 Thread Gu Zheng
When we submit bio with READ_SYNC or WRITE_SYNC, we need to wait a moment for the io completion, current codes only find_data_page() follows the rule, other places missing this step, so add it. Further more, moving the PageUptodate check into f2fs_readpage() to clean up the codes. Signed-off-by:

[PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-30 Thread Gu Zheng
When we submit bio with READ_SYNC or WRITE_SYNC, we need to wait a moment for the io completion, current codes only find_data_page() follows the rule, other places missing this step, so add it. Further more, moving the PageUptodate check into f2fs_readpage() to clean up the codes. Signed-off-by:

Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-30 Thread Jaegeuk Kim
Hi Gu, The original read flow was to avoid redandunt lock/unlock_page() calls. And we should not wait for WRITE_SYNC, since it is just for write priority, not for synchronization of the file system. Thanks, 2013-07-30 (화), 18:06 +0800, Gu Zheng: When we submit bio with READ_SYNC or WRITE_SYNC,

Re: [PATCH] f2fs: add a wait step when submit bio with {READ,WRITE}_SYNC

2013-07-30 Thread Gu Zheng
Hi Kim, On 07/30/2013 08:29 PM, Jaegeuk Kim wrote: Hi Gu, The original read flow was to avoid redandunt lock/unlock_page() calls. Right, this can gain better read performance. But is the wait step after submitting bio with READ_SYNC needless too? And we should not wait for WRITE_SYNC,