Re: [PATCH] firmware: coreboot: Let OF core populate platform device

On Tue, Aug 07, 2018 at 11:00:50PM -0700, Stephen Boyd wrote: > Quoting Brian Norris (2018-08-07 14:41:04) > > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > > @@ -44,8 +43,9 @@ static int coreboot_table_of_remove(struct > > > platform_device *pdev) > > > > > > static const s

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

Quoting Brian Norris (2018-08-07 14:41:04) > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > diff --git a/drivers/firmware/google/coreboot_table-of.c > > b/drivers/firmware/google/coreboot_table-of.c > > index f15bf404c579..270f112bdc54 100644 > > --- a/drivers/firmware/google/co

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

Hi Stephen, Although I already 'Reviewed' this, I noticed another problem when I went to look again: On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > Now that the /firmware/coreboot node in DT is populated by the core DT > platform code with commit 3aa0582fdb82 ("of: platform: popu

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

Thanks for the quick fix! Reviewed-by: Julius Werner

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

Quoting Brian Norris (2018-08-06 10:38:08) > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > Now that the /firmware/coreboot node in DT is populated by the core DT > > platform code with commit 3aa0582fdb82 ("of: platform: populate > > /firmware/ node from of_platform_default_popu

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > Now that the /firmware/coreboot node in DT is populated by the core DT > platform code with commit 3aa0582fdb82 ("of: platform: populate > /firmware/ node from of_platform_default_populate_init()") we should and Does this deserve a 'F

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

On Mon, Aug 6, 2018 at 6:13 PM Stephen Boyd wrote: > > Now that the /firmware/coreboot node in DT is populated by the core DT > platform code with commit 3aa0582fdb82 ("of: platform: populate > /firmware/ node from of_platform_default_populate_init()") we should and > can remove the platform devic

[PATCH] firmware: coreboot: Let OF core populate platform device

Now that the /firmware/coreboot node in DT is populated by the core DT platform code with commit 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") we should and can remove the platform device creation here. Otherwise, the of_platform_device_create() ca