Re: [PATCH] fix crash when using XFS on loopback

2014-01-09 Thread Simon Baatz
Hi Mikulas, On Sat, Jan 04, 2014 at 12:45:45PM -0500, Mikulas Patocka wrote: > The patch 8456a648cf44f14365f1f44de90a3da2526a4776 causes crash in the > LVM2 testsuite on PA-RISC (the crashing test is fsadm.sh). The testsuite > doesn't crash on 3.12, crashes on 3.13-rc1 and later. > > Bad

Re: [PATCH] fix crash when using XFS on loopback

2014-01-09 Thread Pekka Enberg
On Thu, Jan 9, 2014 at 2:19 AM, Andrew Morton wrote: >> cache-misses are reduced by this patchset, roughly 5%. >> And elapsed times are also improved by 3.1% to baseline. > > ah, OK, thanks, useful. A few instructions added to page_mapping() > won't have effects like that! Yup, I merged the

Re: [PATCH] fix crash when using XFS on loopback

2014-01-09 Thread Pekka Enberg
On Thu, Jan 9, 2014 at 2:19 AM, Andrew Morton a...@linux-foundation.org wrote: cache-misses are reduced by this patchset, roughly 5%. And elapsed times are also improved by 3.1% to baseline. ah, OK, thanks, useful. A few instructions added to page_mapping() won't have effects like that!

Re: [PATCH] fix crash when using XFS on loopback

2014-01-09 Thread Simon Baatz
Hi Mikulas, On Sat, Jan 04, 2014 at 12:45:45PM -0500, Mikulas Patocka wrote: The patch 8456a648cf44f14365f1f44de90a3da2526a4776 causes crash in the LVM2 testsuite on PA-RISC (the crashing test is fsadm.sh). The testsuite doesn't crash on 3.12, crashes on 3.13-rc1 and later. Bad Address

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Andrew Morton
On Thu, 9 Jan 2014 09:13:31 +0900 Joonsoo Kim wrote: > On Wed, Jan 08, 2014 at 01:59:30PM -0800, Andrew Morton wrote: > > On Wed, 8 Jan 2014 23:37:49 +0200 Pekka Enberg wrote: > > > > > The patch looks good to me but it probably should go through Andrew's > > > tree. > > > > yup. > > > >

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Joonsoo Kim
On Wed, Jan 08, 2014 at 01:59:30PM -0800, Andrew Morton wrote: > On Wed, 8 Jan 2014 23:37:49 +0200 Pekka Enberg wrote: > > > The patch looks good to me but it probably should go through Andrew's tree. > > yup. > > page_mapping() will be called quite frequently, and adding a new > test-n-branch

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Andrew Morton
On Wed, 8 Jan 2014 23:37:49 +0200 Pekka Enberg wrote: > The patch looks good to me but it probably should go through Andrew's tree. yup. page_mapping() will be called quite frequently, and adding a new test-n-branch in there will be somewhat costly. We might end up with a better kernel if we

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Helge Deller
On 01/08/2014 10:37 PM, Pekka Enberg wrote: On Wed, Jan 8, 2014 at 11:05 PM, Helge Deller wrote: On 01/07/2014 02:41 AM, Joonsoo Kim wrote: On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: Hello, I'm surprised that this

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Pekka Enberg
On Wed, Jan 8, 2014 at 11:05 PM, Helge Deller wrote: > On 01/07/2014 02:41 AM, Joonsoo Kim wrote: >> >> On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: >>> >>> Hi >>> >>> On Mon, 6 Jan 2014, Joonsoo Kim wrote: >>> Hello, I'm surprised that this VM_BUG_ON() has not

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Helge Deller
On 01/07/2014 02:41 AM, Joonsoo Kim wrote: On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: Hello, I'm surprised that this VM_BUG_ON() has not been triggered until now. It was introduced in 2007 by commit (b5fab14). Maybe there is no

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Helge Deller
On 01/07/2014 02:41 AM, Joonsoo Kim wrote: On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: Hello, I'm surprised that this VM_BUG_ON() has not been triggered until now. It was introduced in 2007 by commit (b5fab14). Maybe there is no

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Pekka Enberg
On Wed, Jan 8, 2014 at 11:05 PM, Helge Deller del...@gmx.de wrote: On 01/07/2014 02:41 AM, Joonsoo Kim wrote: On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: Hello, I'm surprised that this VM_BUG_ON() has not been triggered

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Helge Deller
On 01/08/2014 10:37 PM, Pekka Enberg wrote: On Wed, Jan 8, 2014 at 11:05 PM, Helge Deller del...@gmx.de wrote: On 01/07/2014 02:41 AM, Joonsoo Kim wrote: On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: Hello, I'm surprised that

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Andrew Morton
On Wed, 8 Jan 2014 23:37:49 +0200 Pekka Enberg penb...@kernel.org wrote: The patch looks good to me but it probably should go through Andrew's tree. yup. page_mapping() will be called quite frequently, and adding a new test-n-branch in there will be somewhat costly. We might end up with a

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Joonsoo Kim
On Wed, Jan 08, 2014 at 01:59:30PM -0800, Andrew Morton wrote: On Wed, 8 Jan 2014 23:37:49 +0200 Pekka Enberg penb...@kernel.org wrote: The patch looks good to me but it probably should go through Andrew's tree. yup. page_mapping() will be called quite frequently, and adding a new

Re: [PATCH] fix crash when using XFS on loopback

2014-01-08 Thread Andrew Morton
On Thu, 9 Jan 2014 09:13:31 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jan 08, 2014 at 01:59:30PM -0800, Andrew Morton wrote: On Wed, 8 Jan 2014 23:37:49 +0200 Pekka Enberg penb...@kernel.org wrote: The patch looks good to me but it probably should go through Andrew's

Re: [PATCH] fix crash when using XFS on loopback

2014-01-06 Thread Joonsoo Kim
On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: > Hi > > On Mon, 6 Jan 2014, Joonsoo Kim wrote: > > > Hello, > > > > I'm surprised that this VM_BUG_ON() has not been triggered until now. It was > > introduced in 2007 by commit (b5fab14). Maybe there is no person who test > >

Re: [PATCH] fix crash when using XFS on loopback

2014-01-06 Thread Mikulas Patocka
Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: > Hello, > > I'm surprised that this VM_BUG_ON() has not been triggered until now. It was > introduced in 2007 by commit (b5fab14). Maybe there is no person who test > with CONFIG_DEBUG_VM. Last time I tried it, PS-RISC didn't work with CONFIG_DEBUG_VM

Re: [PATCH] fix crash when using XFS on loopback

2014-01-06 Thread Mikulas Patocka
Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: Hello, I'm surprised that this VM_BUG_ON() has not been triggered until now. It was introduced in 2007 by commit (b5fab14). Maybe there is no person who test with CONFIG_DEBUG_VM. Last time I tried it, PS-RISC didn't work with CONFIG_DEBUG_VM at

Re: [PATCH] fix crash when using XFS on loopback

2014-01-06 Thread Joonsoo Kim
On Mon, Jan 06, 2014 at 12:54:22PM -0500, Mikulas Patocka wrote: Hi On Mon, 6 Jan 2014, Joonsoo Kim wrote: Hello, I'm surprised that this VM_BUG_ON() has not been triggered until now. It was introduced in 2007 by commit (b5fab14). Maybe there is no person who test with

Re: [PATCH] fix crash when using XFS on loopback

2014-01-05 Thread Joonsoo Kim
On Sat, Jan 04, 2014 at 12:45:45PM -0500, Mikulas Patocka wrote: > The patch 8456a648cf44f14365f1f44de90a3da2526a4776 causes crash in the > LVM2 testsuite on PA-RISC (the crashing test is fsadm.sh). The testsuite > doesn't crash on 3.12, crashes on 3.13-rc1 and later. > > Bad Address (null

Re: [PATCH] fix crash when using XFS on loopback

2014-01-05 Thread Joonsoo Kim
On Sat, Jan 04, 2014 at 12:45:45PM -0500, Mikulas Patocka wrote: The patch 8456a648cf44f14365f1f44de90a3da2526a4776 causes crash in the LVM2 testsuite on PA-RISC (the crashing test is fsadm.sh). The testsuite doesn't crash on 3.12, crashes on 3.13-rc1 and later. Bad Address (null pointer

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread Mikulas Patocka
On Sat, 4 Jan 2014, John David Anglin wrote: > On 4-Jan-14, at 2:55 PM, Mikulas Patocka wrote: > > > On Sat, 4 Jan 2014, John David Anglin wrote: > > > > > On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: > > > > > > > * flush_dcache_page asks for the list of userspace mappings, however > >

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread John David Anglin
On 4-Jan-14, at 2:55 PM, Mikulas Patocka wrote: On Sat, 4 Jan 2014, John David Anglin wrote: On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: * flush_dcache_page asks for the list of userspace mappings, however that page->mapping field is reused by the slab subsystem for a different

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread Mikulas Patocka
On Sat, 4 Jan 2014, John David Anglin wrote: > On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: > > > * flush_dcache_page asks for the list of userspace mappings, however that > > page->mapping field is reused by the slab subsystem for a different > > purpose. This causes the crash. > > I'd

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread John David Anglin
On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: * flush_dcache_page asks for the list of userspace mappings, however that page->mapping field is reused by the slab subsystem for a different purpose. This causes the crash. I'd noticed the other day that the parisc implementation of

[PATCH] fix crash when using XFS on loopback

2014-01-04 Thread Mikulas Patocka
The patch 8456a648cf44f14365f1f44de90a3da2526a4776 causes crash in the LVM2 testsuite on PA-RISC (the crashing test is fsadm.sh). The testsuite doesn't crash on 3.12, crashes on 3.13-rc1 and later. Bad Address (null pointer deref?): Code=15 regs=00413edd89a0 (Addr=06202224647d) CPU: 3

[PATCH] fix crash when using XFS on loopback

2014-01-04 Thread Mikulas Patocka
The patch 8456a648cf44f14365f1f44de90a3da2526a4776 causes crash in the LVM2 testsuite on PA-RISC (the crashing test is fsadm.sh). The testsuite doesn't crash on 3.12, crashes on 3.13-rc1 and later. Bad Address (null pointer deref?): Code=15 regs=00413edd89a0 (Addr=06202224647d) CPU: 3

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread John David Anglin
On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: * flush_dcache_page asks for the list of userspace mappings, however that page-mapping field is reused by the slab subsystem for a different purpose. This causes the crash. I'd noticed the other day that the parisc implementation of

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread Mikulas Patocka
On Sat, 4 Jan 2014, John David Anglin wrote: On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: * flush_dcache_page asks for the list of userspace mappings, however that page-mapping field is reused by the slab subsystem for a different purpose. This causes the crash. I'd noticed the

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread John David Anglin
On 4-Jan-14, at 2:55 PM, Mikulas Patocka wrote: On Sat, 4 Jan 2014, John David Anglin wrote: On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: * flush_dcache_page asks for the list of userspace mappings, however that page-mapping field is reused by the slab subsystem for a different

Re: [PATCH] fix crash when using XFS on loopback

2014-01-04 Thread Mikulas Patocka
On Sat, 4 Jan 2014, John David Anglin wrote: On 4-Jan-14, at 2:55 PM, Mikulas Patocka wrote: On Sat, 4 Jan 2014, John David Anglin wrote: On 4-Jan-14, at 12:45 PM, Mikulas Patocka wrote: * flush_dcache_page asks for the list of userspace mappings, however that