Re: [PATCH] fix group stop with exit race

2007-12-06 Thread Oleg Nesterov
On 12/05, Davide Libenzi wrote: > > On Wed, 5 Dec 2007, Oleg Nesterov wrote: > > > do_signal_stop() counts all sub-thread and sets ->group_stop_count > > accordingly. > > Every thread should decrement ->group_stop_count and stop, the last one > > should > > notify the parent. > > > > However a

Re: [PATCH] fix group stop with exit race

2007-12-06 Thread Oleg Nesterov
On 12/05, Davide Libenzi wrote: On Wed, 5 Dec 2007, Oleg Nesterov wrote: do_signal_stop() counts all sub-thread and sets -group_stop_count accordingly. Every thread should decrement -group_stop_count and stop, the last one should notify the parent. However a sub-thread can exit

Re: [PATCH] fix group stop with exit race

2007-12-05 Thread Davide Libenzi
On Wed, 5 Dec 2007, Oleg Nesterov wrote: > do_signal_stop() counts all sub-thread and sets ->group_stop_count > accordingly. > Every thread should decrement ->group_stop_count and stop, the last one should > notify the parent. > > However a sub-thread can exit before it notices the

[PATCH] fix group stop with exit race

2007-12-05 Thread Oleg Nesterov
do_signal_stop() counts all sub-thread and sets ->group_stop_count accordingly. Every thread should decrement ->group_stop_count and stop, the last one should notify the parent. However a sub-thread can exit before it notices the signal_pending(), or it may be somewhere in do_exit() already. In

[PATCH] fix group stop with exit race

2007-12-05 Thread Oleg Nesterov
do_signal_stop() counts all sub-thread and sets -group_stop_count accordingly. Every thread should decrement -group_stop_count and stop, the last one should notify the parent. However a sub-thread can exit before it notices the signal_pending(), or it may be somewhere in do_exit() already. In

Re: [PATCH] fix group stop with exit race

2007-12-05 Thread Davide Libenzi
On Wed, 5 Dec 2007, Oleg Nesterov wrote: do_signal_stop() counts all sub-thread and sets -group_stop_count accordingly. Every thread should decrement -group_stop_count and stop, the last one should notify the parent. However a sub-thread can exit before it notices the signal_pending(), or