Re: [PATCH] fix voyager compile after machine_emergency_restart breakage
James Bottomley <[EMAIL PROTECTED]> writes: > [PATCH] i386: Implement machine_emergency_reboot > > introduced this new function into arch/i386/reboot.c. However, > subarchitectures are entitled to implement their own copies of reboot.c > from which this new function is now missing. > > It looks like visws will also need a similar fixup Yes, except it looks like it can benefit from a real machine_emergency_restart, if the smp_send_stop in there is the one I am familiar with. My apologies I am always finding the subarchitecture support on x86 non-intuitive. When you are looking at the primary code path there is nothing to indicate that there is a secondary code path out in the machine specific files. Most other architectures have a machine vector so you can compile for multiple subarchitectures simultaneously and then switch between them, at run time. With an optimization that if you only compile for one subarchitecture the indirect function call overhead disappears. Anyway I will see about generating the trivial patch later today. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fix voyager compile after machine_emergency_restart breakage
James Bottomley [EMAIL PROTECTED] writes: [PATCH] i386: Implement machine_emergency_reboot introduced this new function into arch/i386/reboot.c. However, subarchitectures are entitled to implement their own copies of reboot.c from which this new function is now missing. It looks like visws will also need a similar fixup Yes, except it looks like it can benefit from a real machine_emergency_restart, if the smp_send_stop in there is the one I am familiar with. My apologies I am always finding the subarchitecture support on x86 non-intuitive. When you are looking at the primary code path there is nothing to indicate that there is a secondary code path out in the machine specific files. Most other architectures have a machine vector so you can compile for multiple subarchitectures simultaneously and then switch between them, at run time. With an optimization that if you only compile for one subarchitecture the indirect function call overhead disappears. Anyway I will see about generating the trivial patch later today. Eric - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fix voyager compile after machine_emergency_restart breakage
[PATCH] i386: Implement machine_emergency_reboot
introduced this new function into arch/i386/reboot.c. However,
subarchitectures are entitled to implement their own copies of reboot.c
from which this new function is now missing.
It looks like visws will also need a similar fixup
Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
diff --git a/arch/i386/mach-voyager/voyager_basic.c
b/arch/i386/mach-voyager/voyager_basic.c
--- a/arch/i386/mach-voyager/voyager_basic.c
+++ b/arch/i386/mach-voyager/voyager_basic.c
@@ -279,6 +279,13 @@ machine_restart(char *cmd)
}
void
+machine_emergency_restart(void)
+{
+ /*for now, just hook this to a warm restart */
+ machine_restart(NULL);
+}
+
+void
mca_nmi_hook(void)
{
__u8 dumpval __attribute__((unused)) = inb(0xf823);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fix voyager compile after machine_emergency_restart breakage
[PATCH] i386: Implement machine_emergency_reboot
introduced this new function into arch/i386/reboot.c. However,
subarchitectures are entitled to implement their own copies of reboot.c
from which this new function is now missing.
It looks like visws will also need a similar fixup
Signed-off-by: James Bottomley [EMAIL PROTECTED]
diff --git a/arch/i386/mach-voyager/voyager_basic.c
b/arch/i386/mach-voyager/voyager_basic.c
--- a/arch/i386/mach-voyager/voyager_basic.c
+++ b/arch/i386/mach-voyager/voyager_basic.c
@@ -279,6 +279,13 @@ machine_restart(char *cmd)
}
void
+machine_emergency_restart(void)
+{
+ /*for now, just hook this to a warm restart */
+ machine_restart(NULL);
+}
+
+void
mca_nmi_hook(void)
{
__u8 dumpval __attribute__((unused)) = inb(0xf823);
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
