Re: [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl()

2016-07-04 Thread David Sterba 
On Sun, Jul 03, 2016 at 05:40:10AM +0100, Salah Triki wrote:
> size contains the value returned by posix_acl_from_xattr(), which
> returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
> replace -ENOENT by -ERANGE.
> 
> Signed-off-by: Salah Triki 

Reviewed-by: David Sterba

Re: [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl()

2016-07-04 Thread David Sterba 
On Sun, Jul 03, 2016 at 05:40:10AM +0100, Salah Triki wrote:
> size contains the value returned by posix_acl_from_xattr(), which
> returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
> replace -ENOENT by -ERANGE.
> 
> Signed-off-by: Salah Triki 

Reviewed-by: David Sterba

[PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl()

2016-07-02 Thread Salah Triki 
size contains the value returned by posix_acl_from_xattr(), which
returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
replace -ENOENT by -ERANGE.

Signed-off-by: Salah Triki 
---
 fs/btrfs/acl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 67a6077..53bb7af 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -55,8 +55,7 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
}
if (size > 0) {
acl = posix_acl_from_xattr(_user_ns, value, size);
-   } else if (size == -ENOENT || size == -ENODATA || size == 0) {
-   /* FIXME, who returns -ENOENT?  I think nobody */
+   } else if (size == -ERANGE || size == -ENODATA || size == 0) {
acl = NULL;
} else {
acl = ERR_PTR(-EIO);
-- 
1.9.1

[PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl()

2016-07-02 Thread Salah Triki 
size contains the value returned by posix_acl_from_xattr(), which
returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
replace -ENOENT by -ERANGE.

Signed-off-by: Salah Triki 
---
 fs/btrfs/acl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 67a6077..53bb7af 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -55,8 +55,7 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
}
if (size > 0) {
acl = posix_acl_from_xattr(_user_ns, value, size);
-   } else if (size == -ENOENT || size == -ENODATA || size == 0) {
-   /* FIXME, who returns -ENOENT?  I think nobody */
+   } else if (size == -ERANGE || size == -ENODATA || size == 0) {
acl = NULL;
} else {
acl = ERR_PTR(-EIO);
-- 
1.9.1