Re: [PATCH] fs: fix lost error code in dio_complete

2018-11-01 Thread Shah, Amit
On Do, 2018-11-01 at 09:03 +0100, Maximilian Heyne wrote: > On 10/31/18 10:24 AM, Shah, Amit wrote: > > > > On Di, 2018-10-30 at 21:57 +, Maximilian Heyne wrote: > > > > > > [...] > > > > > > diff --git a/fs/direct-io.c b/fs/direct-io.c > > > index 093fb54cd316..199146036093 100644 > > >

Re: [PATCH] fs: fix lost error code in dio_complete

2018-11-01 Thread Shah, Amit
On Do, 2018-11-01 at 09:03 +0100, Maximilian Heyne wrote: > On 10/31/18 10:24 AM, Shah, Amit wrote: > > > > On Di, 2018-10-30 at 21:57 +, Maximilian Heyne wrote: > > > > > > [...] > > > > > > diff --git a/fs/direct-io.c b/fs/direct-io.c > > > index 093fb54cd316..199146036093 100644 > > >

Re: [PATCH] fs: fix lost error code in dio_complete

2018-11-01 Thread Maximilian Heyne
On 10/31/18 10:24 AM, Shah, Amit wrote: On Di, 2018-10-30 at 21:57 +, Maximilian Heyne wrote: [...] diff --git a/fs/direct-io.c b/fs/direct-io.c index 093fb54cd316..199146036093 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -325,8 +325,8 @@ static ssize_t dio_complete(struct dio

Re: [PATCH] fs: fix lost error code in dio_complete

2018-11-01 Thread Maximilian Heyne
On 10/31/18 10:24 AM, Shah, Amit wrote: On Di, 2018-10-30 at 21:57 +, Maximilian Heyne wrote: [...] diff --git a/fs/direct-io.c b/fs/direct-io.c index 093fb54cd316..199146036093 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -325,8 +325,8 @@ static ssize_t dio_complete(struct dio

Re: [PATCH] fs: fix lost error code in dio_complete

2018-10-31 Thread Shah, Amit
On Di, 2018-10-30 at 21:57 +, Maximilian Heyne wrote: > commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the > generic_write_sync prototype") reworked callers of generic_write_sync(), > and ended up dropping the error return for the directio path. Prior to > that commit, in

Re: [PATCH] fs: fix lost error code in dio_complete

2018-10-31 Thread Shah, Amit
On Di, 2018-10-30 at 21:57 +, Maximilian Heyne wrote: > commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the > generic_write_sync prototype") reworked callers of generic_write_sync(), > and ended up dropping the error return for the directio path. Prior to > that commit, in

Re: [PATCH] fs: fix lost error code in dio_complete

2018-10-30 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH] fs: fix lost error code in dio_complete

2018-10-30 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH] fs: fix lost error code in dio_complete

2018-10-30 Thread Maximilian Heyne
commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the generic_write_sync prototype") reworked callers of generic_write_sync(), and ended up dropping the error return for the directio path. Prior to that commit, in dio_complete(), an error would be bubbled up the stack, but after that

[PATCH] fs: fix lost error code in dio_complete

2018-10-30 Thread Maximilian Heyne
commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the generic_write_sync prototype") reworked callers of generic_write_sync(), and ended up dropping the error return for the directio path. Prior to that commit, in dio_complete(), an error would be bubbled up the stack, but after that