Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-11 Thread Vijay Khemka
On 10/10/19, 8:11 PM, "Benjamin Herrenschmidt" wrote: On Thu, 2019-10-10 at 19:15 +, Vijay Khemka wrote: > Any news on this ? AST2400 has no HW checksum logic in HW, AST2500 > should work for IPV4 fine, we should only selectively disable it for > IPV6. >

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Benjamin Herrenschmidt
On Thu, 2019-10-10 at 19:15 +, Vijay Khemka wrote: > Any news on this ? AST2400 has no HW checksum logic in HW, AST2500 > should work for IPV4 fine, we should only selectively disable it for > IPV6. > > Ben, I have already sent v2 for this with requested change which only disable

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Vijay Khemka
On 10/8/19, 9:37 PM, "Benjamin Herrenschmidt" wrote: On Wed, 2019-09-11 at 14:48 +, Joel Stanley wrote: > Hi Ben, > > On Tue, 10 Sep 2019 at 22:05, Florian Fainelli > wrote: > > > > On 9/10/19 2:37 PM, Vijay Khemka wrote: > > > HW checksum generation is

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-09 Thread Benjamin Herrenschmidt
On Wed, 2019-10-09 at 14:18 -0400, Oskar Senft wrote: > Does HW in the AST2500 actually perform the HW checksum calculation, > or would that be the responsibility of the NIC that it's talking to > via NC-SI? I wouldn't rely on the NC-SI NIC for UDP/TCP checksums. We should be providing it with

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-09 Thread Oskar Senft
Does HW in the AST2500 actually perform the HW checksum calculation, or would that be the responsibility of the NIC that it's talking to via NC-SI? (Sorry for the double posting! I had HTML mode enabled by default which causes the e-mail to be dropped in some places) On Wed, Oct 9, 2019 at

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-08 Thread Benjamin Herrenschmidt
On Wed, 2019-09-11 at 14:48 +, Joel Stanley wrote: > Hi Ben, > > On Tue, 10 Sep 2019 at 22:05, Florian Fainelli > wrote: > > > > On 9/10/19 2:37 PM, Vijay Khemka wrote: > > > HW checksum generation is not working for AST2500, specially with > > > IPV6 > > > over NCSI. All TCP packets with

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/11/19, 11:34 AM, "Florian Fainelli" wrote: On 9/11/19 11:30 AM, Vijay Khemka wrote: > > > On 9/10/19, 4:08 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: > > > > On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote:

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Florian Fainelli
On 9/11/19 11:30 AM, Vijay Khemka wrote: > > > On 9/10/19, 4:08 PM, "Linux-aspeed on behalf of Vijay Khemka" > vijaykhe...@fb.com> wrote: > > > > On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" > vijaykhe...@fb.com> wrote: > > > >

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/10/19, 4:08 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/11/19, 7:49 AM, "Joel Stanley" wrote: Hi Ben, On Tue, 10 Sep 2019 at 22:05, Florian Fainelli wrote: > > On 9/10/19 2:37 PM, Vijay Khemka wrote: > > HW checksum generation is not working for AST2500, specially with IPV6 > > over NCSI. All TCP packets with

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Joel Stanley
Hi Ben, On Tue, 10 Sep 2019 at 22:05, Florian Fainelli wrote: > > On 9/10/19 2:37 PM, Vijay Khemka wrote: > > HW checksum generation is not working for AST2500, specially with IPV6 > > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > > it works perfectly fine with IPV6. > >

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfectly fine with IPV6. >

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfectly fine with IPV6. >

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Florian Fainelli
On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfectly fine with IPV6. > > Verified with IPV6 enabled and can do ssh. How about IPv4, do these