Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Linus Torvalds
On Wed, Aug 9, 2017 at 8:31 AM, Mel Gorman wrote: > > Linus, can you pick it up directly please? Done. Linus

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Linus Torvalds
On Wed, Aug 9, 2017 at 8:31 AM, Mel Gorman wrote: > > Linus, can you pick it up directly please? Done. Linus

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
On Wed, Aug 09, 2017 at 05:08:34PM +0200, Peter Zijlstra wrote: > On Wed, Aug 09, 2017 at 03:43:09PM +0100, Mel Gorman wrote: > > On Wed, Aug 09, 2017 at 03:05:19PM +0100, Mark Rutland wrote: > > > > diff --git a/kernel/futex.c b/kernel/futex.c > > > > index 16dbe4c93895..f50b434756c1 100644 > > >

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
On Wed, Aug 09, 2017 at 05:08:34PM +0200, Peter Zijlstra wrote: > On Wed, Aug 09, 2017 at 03:43:09PM +0100, Mel Gorman wrote: > > On Wed, Aug 09, 2017 at 03:05:19PM +0100, Mark Rutland wrote: > > > > diff --git a/kernel/futex.c b/kernel/futex.c > > > > index 16dbe4c93895..f50b434756c1 100644 > > >

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Peter Zijlstra
On Wed, Aug 09, 2017 at 03:43:09PM +0100, Mel Gorman wrote: > On Wed, Aug 09, 2017 at 03:05:19PM +0100, Mark Rutland wrote: > > > diff --git a/kernel/futex.c b/kernel/futex.c > > > index 16dbe4c93895..f50b434756c1 100644 > > > --- a/kernel/futex.c > > > +++ b/kernel/futex.c > > > @@ -670,13

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Peter Zijlstra
On Wed, Aug 09, 2017 at 03:43:09PM +0100, Mel Gorman wrote: > On Wed, Aug 09, 2017 at 03:05:19PM +0100, Mark Rutland wrote: > > > diff --git a/kernel/futex.c b/kernel/futex.c > > > index 16dbe4c93895..f50b434756c1 100644 > > > --- a/kernel/futex.c > > > +++ b/kernel/futex.c > > > @@ -670,13

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
On Wed, Aug 09, 2017 at 03:05:19PM +0100, Mark Rutland wrote: > > diff --git a/kernel/futex.c b/kernel/futex.c > > index 16dbe4c93895..f50b434756c1 100644 > > --- a/kernel/futex.c > > +++ b/kernel/futex.c > > @@ -670,13 +670,14 @@ get_futex_key(u32 __user *uaddr, int fshared, union > > futex_key

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
On Wed, Aug 09, 2017 at 03:05:19PM +0100, Mark Rutland wrote: > > diff --git a/kernel/futex.c b/kernel/futex.c > > index 16dbe4c93895..f50b434756c1 100644 > > --- a/kernel/futex.c > > +++ b/kernel/futex.c > > @@ -670,13 +670,14 @@ get_futex_key(u32 __user *uaddr, int fshared, union > > futex_key

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mark Rutland
On Wed, Aug 09, 2017 at 08:27:11AM +0100, Mel Gorman wrote: > Commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in > get_futex_key()") removed an unnecessary lock_page() with the side-effect > that page->mapping needed to be treated very carefully. Two defensive > warnings were added

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mark Rutland
On Wed, Aug 09, 2017 at 08:27:11AM +0100, Mel Gorman wrote: > Commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in > get_futex_key()") removed an unnecessary lock_page() with the side-effect > that page->mapping needed to be treated very carefully. Two defensive > warnings were added

[PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
Commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in get_futex_key()") removed an unnecessary lock_page() with the side-effect that page->mapping needed to be treated very carefully. Two defensive warnings were added in case any assumption was missed and the first warning assumed a

[PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
Commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in get_futex_key()") removed an unnecessary lock_page() with the side-effect that page->mapping needed to be treated very carefully. Two defensive warnings were added in case any assumption was missed and the first warning assumed a

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Davidlohr Bueso
On Wed, 09 Aug 2017, Mel Gorman wrote: @@ -676,7 +676,7 @@ get_futex_key(u32 __user *uaddr, int fshared, union futex_key *key, int rw) * cases, therefore a successful atomic_inc return below will * guarantee that get_futex_key() will still imply smp_mb();

Re: [PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Davidlohr Bueso
On Wed, 09 Aug 2017, Mel Gorman wrote: @@ -676,7 +676,7 @@ get_futex_key(u32 __user *uaddr, int fshared, union futex_key *key, int rw) * cases, therefore a successful atomic_inc return below will * guarantee that get_futex_key() will still imply smp_mb();

[PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
Commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in get_futex_key()") removed an unnecessary lock_page() with the side-effect that page->mapping needed to be treated very carefully. Two defensive warnings were added in case any assumption was wrong with the first warning assuming a

[PATCH] futex: Remove unnecessary warning from get_futex_key

2017-08-09 Thread Mel Gorman
Commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in get_futex_key()") removed an unnecessary lock_page() with the side-effect that page->mapping needed to be treated very carefully. Two defensive warnings were added in case any assumption was wrong with the first warning assuming a