Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-24 Thread Masahiro Yamada
On Wed, Feb 24, 2021 at 10:46 AM Guenter Roeck wrote: > > On Tue, Feb 23, 2021 at 07:03:47PM +0100, Heiko Carstens wrote: > > On Tue, Feb 23, 2021 at 09:41:40AM -0800, Guenter Roeck wrote: > > > > I tried to explain why we don't want to set COMPILE_TEST for s390 > > > > anymore. It overrides

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-23 Thread Guenter Roeck
On Tue, Feb 23, 2021 at 07:03:47PM +0100, Heiko Carstens wrote: > On Tue, Feb 23, 2021 at 09:41:40AM -0800, Guenter Roeck wrote: > > > I tried to explain why we don't want to set COMPILE_TEST for s390 > > > anymore. It overrides architecture dependencies in Kconfig, and lots > > > of drivers do

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-23 Thread Kees Cook
On Tue, Feb 23, 2021 at 07:03:47PM +0100, Heiko Carstens wrote: > Well, if we would have e.g. RANDCONFIG, then we could probably revert > 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") and > instead let COMPILE_TEST depend on !RANDCONFIG. > I think this _could_ solve all common

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-23 Thread Heiko Carstens
On Tue, Feb 23, 2021 at 09:41:40AM -0800, Guenter Roeck wrote: > > I tried to explain why we don't want to set COMPILE_TEST for s390 > > anymore. It overrides architecture dependencies in Kconfig, and lots > > of drivers do not set dependencies for HAS_IOMEM, HAS_DMA, and friends > > correctly. >

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-23 Thread Guenter Roeck
On Tue, Feb 23, 2021 at 12:54:10PM +0100, Heiko Carstens wrote: > On Mon, Feb 22, 2021 at 08:03:31AM -0800, Guenter Roeck wrote: > > > Maybe, we can add something like CONFIG_SUPPRESS_NOISY_TESTS, > > > which is set to y by all{yes,mod}config. > > > > > > This is self-documenting, so we do not

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-23 Thread Heiko Carstens
On Mon, Feb 22, 2021 at 08:03:31AM -0800, Guenter Roeck wrote: > > Maybe, we can add something like CONFIG_SUPPRESS_NOISY_TESTS, > > which is set to y by all{yes,mod}config. > > > > This is self-documenting, so we do not need the '# too noisy' comment. > > > > > > > > config

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-22 Thread Guenter Roeck
On 2/22/21 7:45 AM, Masahiro Yamada wrote: > On Tue, Feb 23, 2021 at 12:18 AM Guenter Roeck wrote: >> >> On 2/22/21 4:05 AM, Heiko Carstens wrote: >>> On Sun, Feb 21, 2021 at 02:56:50PM -0800, Guenter Roeck wrote: Commit 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390")

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-22 Thread Masahiro Yamada
On Tue, Feb 23, 2021 at 12:18 AM Guenter Roeck wrote: > > On 2/22/21 4:05 AM, Heiko Carstens wrote: > > On Sun, Feb 21, 2021 at 02:56:50PM -0800, Guenter Roeck wrote: > >> Commit 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") > >> disabled > >> COMPILE_TEST for s390. At the

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-22 Thread Guenter Roeck
On 2/22/21 4:05 AM, Heiko Carstens wrote: > On Sun, Feb 21, 2021 at 02:56:50PM -0800, Guenter Roeck wrote: >> Commit 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") >> disabled >> COMPILE_TEST for s390. At the same time, "make allmodconfig/allyesconfig" for >> s390 is still

Re: [PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-22 Thread Heiko Carstens
On Sun, Feb 21, 2021 at 02:56:50PM -0800, Guenter Roeck wrote: > Commit 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") > disabled > COMPILE_TEST for s390. At the same time, "make allmodconfig/allyesconfig" for > s390 is still supported. However, it generates thousands of

[PATCH] gcc-plugins: Disable GCC_PLUGIN_CYC_COMPLEXITY for s390

2021-02-21 Thread Guenter Roeck
Commit 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390") disabled COMPILE_TEST for s390. At the same time, "make allmodconfig/allyesconfig" for s390 is still supported. However, it generates thousands of compiler messages such as the following, making it highly impractical to run.