Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Fangrui Song
On 2021-03-12, Nick Desaulniers wrote: On Fri, Mar 12, 2021 at 12:25 PM 'Fangrui Song' via Clang Built Linux wrote: function_name can be unconditionally deleted. It is not used by llvm-cov gcov. You'll need to delete a few assignments to gcov_info_free but you can then unify the

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nathan Chancellor
On Fri, Mar 12, 2021 at 01:57:47PM -0800, 'Nick Desaulniers' via Clang Built Linux wrote: > On Fri, Mar 12, 2021 at 12:51 PM Nathan Chancellor wrote: > > > > On Fri, Mar 12, 2021 at 12:14:42PM -0800, Nick Desaulniers wrote: > > > On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor > > > wrote:

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nick Desaulniers
On Fri, Mar 12, 2021 at 12:25 PM 'Fangrui Song' via Clang Built Linux wrote: > > function_name can be unconditionally deleted. It is not used by llvm-cov > gcov. You'll need to delete a few assignments to gcov_info_free but you > can then unify the gcov_fn_info_dup and gcov_info_free

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nick Desaulniers
On Fri, Mar 12, 2021 at 12:51 PM Nathan Chancellor wrote: > > On Fri, Mar 12, 2021 at 12:14:42PM -0800, Nick Desaulniers wrote: > > On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor > > wrote: > > > > > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > > > > LLVM changed

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nathan Chancellor
On Fri, Mar 12, 2021 at 12:14:42PM -0800, Nick Desaulniers wrote: > On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor wrote: > > > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > > > LLVM changed the expected function signatures for llvm_gcda_start_file() > > > and

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nick Desaulniers
On Fri, Mar 12, 2021 at 12:14 PM Nick Desaulniers wrote: > > On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor wrote: > > > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > > > LLVM changed the expected function signatures for llvm_gcda_start_file() > > > and

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Fangrui Song
On 2021-03-12, Nick Desaulniers wrote: LLVM changed the expected function signatures for llvm_gcda_start_file() and llvm_gcda_emit_function() in the clang-11 release. Users of clang-11 or newer may have noticed their kernels failing to boot due to a panic when enabling CONFIG_GCOV_KERNEL=y

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nick Desaulniers
On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor wrote: > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > > LLVM changed the expected function signatures for llvm_gcda_start_file() > > and llvm_gcda_emit_function() in the clang-11 release. Users of clang-11 > > or newer

Re: [PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nathan Chancellor
On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > LLVM changed the expected function signatures for llvm_gcda_start_file() > and llvm_gcda_emit_function() in the clang-11 release. Users of clang-11 > or newer may have noticed their kernels failing to boot due to a panic > when

[PATCH] gcov: fix clang-11+ support

2021-03-12 Thread Nick Desaulniers
LLVM changed the expected function signatures for llvm_gcda_start_file() and llvm_gcda_emit_function() in the clang-11 release. Users of clang-11 or newer may have noticed their kernels failing to boot due to a panic when enabling CONFIG_GCOV_KERNEL=y +CONFIG_GCOV_PROFILE_ALL=y. Fix up the