Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock

2017-06-13 Thread Jin Qian
I meant that the patch needs Cc: sta...@vger.kernel.org. Thanks, jin On Mon, Jun 12, 2017 at 11:02 PM, Greg Kroah-Hartman wrote: > On Fri, Jun 09, 2017 at 12:15:42PM -0700, Jin Qian wrote: >> Reviewed-by: Jin Qian >> >> Can we merge this to

Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock

2017-06-13 Thread Greg Kroah-Hartman
On Fri, Jun 09, 2017 at 12:15:42PM -0700, Jin Qian wrote: > Reviewed-by: Jin Qian > > Can we merge this to stable? I don't understand the question, what kernel(s) exactly do you want this commit to be added to? thanks, greg k-h

Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock

2017-06-09 Thread Jin Qian
Reviewed-by: Jin Qian Can we merge this to stable? Thanks! jin On Mon, May 22, 2017 at 11:48 AM, Alan Cox wrote: > On Mon, 22 May 2017 13:51:52 +0200 > Michal Hocko wrote: > >> On Sun 21-05-17 09:48:36, Michal Hocko wrote: >>

Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock

2017-05-22 Thread Alan Cox
On Mon, 22 May 2017 13:51:52 +0200 Michal Hocko wrote: > On Sun 21-05-17 09:48:36, Michal Hocko wrote: > > On Sun 21-05-17 00:45:46, Wei Yongjun wrote: > > > From: Wei Yongjun > > > > > > The function get_free_pipe_id_locked() is called from > > >

Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock

2017-05-22 Thread Michal Hocko
On Sun 21-05-17 09:48:36, Michal Hocko wrote: > On Sun 21-05-17 00:45:46, Wei Yongjun wrote: > > From: Wei Yongjun > > > > The function get_free_pipe_id_locked() is called from > > goldfish_pipe_open() with a lock is held, so we should > > use GFP_ATOMIC instead of

Re: [PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock

2017-05-21 Thread Michal Hocko
On Sun 21-05-17 00:45:46, Wei Yongjun wrote: > From: Wei Yongjun > > The function get_free_pipe_id_locked() is called from > goldfish_pipe_open() with a lock is held, so we should > use GFP_ATOMIC instead of GFP_KERNEL. Why is GFP_NOWAIT insufficient? Does this path

[PATCH] goldfish_pipe: use GFP_ATOMIC under spin lock

2017-05-20 Thread Wei Yongjun
From: Wei Yongjun The function get_free_pipe_id_locked() is called from goldfish_pipe_open() with a lock is held, so we should use GFP_ATOMIC instead of GFP_KERNEL. Signed-off-by: Wei Yongjun --- drivers/platform/goldfish/goldfish_pipe.c | 2 +-