Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-12 Thread Mark Brown
On Thu, Oct 11, 2018 at 08:41:16PM +0200, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 7:54 PM Mark Brown wrote: > > Other regulators that have GPIO control for their enables do their own > > requests (as does the core) so don't they all need to set the flag > > GPIOD_FLAGS_BIT_NONEXCLUSIVE

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-12 Thread Mark Brown
On Thu, Oct 11, 2018 at 08:41:16PM +0200, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 7:54 PM Mark Brown wrote: > > Other regulators that have GPIO control for their enables do their own > > requests (as does the core) so don't they all need to set the flag > > GPIOD_FLAGS_BIT_NONEXCLUSIVE

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-12 Thread Jon Hunter
Hi Linus, On 11/10/18 15:35, Linus Walleij wrote: > This allows nonexclusive (simultaneous) access to a single > GPIO line for the fixed regulator enable line. This happens > when several regulators use the same GPIO for enabling and > disabling a regulator, and all need a handle on their GPIO >

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-12 Thread Jon Hunter
Hi Linus, On 11/10/18 15:35, Linus Walleij wrote: > This allows nonexclusive (simultaneous) access to a single > GPIO line for the fixed regulator enable line. This happens > when several regulators use the same GPIO for enabling and > disabling a regulator, and all need a handle on their GPIO >

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Linus Walleij
On Thu, Oct 11, 2018 at 7:54 PM Mark Brown wrote: > On Thu, Oct 11, 2018 at 07:01:13PM +0200, Linus Walleij wrote: > > On Thu, Oct 11, 2018 at 4:43 PM Mark Brown wrote: > > > On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > > > > enable line so you don't need to use the bus to do

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Linus Walleij
On Thu, Oct 11, 2018 at 7:54 PM Mark Brown wrote: > On Thu, Oct 11, 2018 at 07:01:13PM +0200, Linus Walleij wrote: > > On Thu, Oct 11, 2018 at 4:43 PM Mark Brown wrote: > > > On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > > > > enable line so you don't need to use the bus to do

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Mark Brown
On Thu, Oct 11, 2018 at 07:01:13PM +0200, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 4:43 PM Mark Brown wrote: > > On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > > enable line so you don't need to use the bus to do the enables. That > > should just be a case of adding this

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Mark Brown
On Thu, Oct 11, 2018 at 07:01:13PM +0200, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 4:43 PM Mark Brown wrote: > > On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > > enable line so you don't need to use the bus to do the enables. That > > should just be a case of adding this

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Linus Walleij
On Thu, Oct 11, 2018 at 4:43 PM Mark Brown wrote: > On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > > > + /* > > + * Some fixed regulators share the enable line between two > > + * regulators which makes it necessary to get a handle on the > > + * same

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Linus Walleij
On Thu, Oct 11, 2018 at 4:43 PM Mark Brown wrote: > On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > > > + /* > > + * Some fixed regulators share the enable line between two > > + * regulators which makes it necessary to get a handle on the > > + * same

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Marek Szyprowski
Hi Linus, On 2018-10-11 16:35, Linus Walleij wrote: > This allows nonexclusive (simultaneous) access to a single > GPIO line for the fixed regulator enable line. This happens > when several regulators use the same GPIO for enabling and > disabling a regulator, and all need a handle on their GPIO

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Marek Szyprowski
Hi Linus, On 2018-10-11 16:35, Linus Walleij wrote: > This allows nonexclusive (simultaneous) access to a single > GPIO line for the fixed regulator enable line. This happens > when several regulators use the same GPIO for enabling and > disabling a regulator, and all need a handle on their GPIO

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Mark Brown
On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > + /* > + * Some fixed regulators share the enable line between two > + * regulators which makes it necessary to get a handle on the > + * same descriptor for two different consumers. This will get > + * the

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Mark Brown
On Thu, Oct 11, 2018 at 04:35:31PM +0200, Linus Walleij wrote: > + /* > + * Some fixed regulators share the enable line between two > + * regulators which makes it necessary to get a handle on the > + * same descriptor for two different consumers. This will get > + * the

[PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Linus Walleij
This allows nonexclusive (simultaneous) access to a single GPIO line for the fixed regulator enable line. This happens when several regulators use the same GPIO for enabling and disabling a regulator, and all need a handle on their GPIO descriptor. This solution with a special flag is not

[PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-11 Thread Linus Walleij
This allows nonexclusive (simultaneous) access to a single GPIO line for the fixed regulator enable line. This happens when several regulators use the same GPIO for enabling and disabling a regulator, and all need a handle on their GPIO descriptor. This solution with a special flag is not