Re: [PATCH] gpio: bd7xxxx: use helper variable for pdev->dev

[Vaittinen, Matti]

Thanks for making this better :)

On Wed, 2021-01-06 at 11:11 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski 
> 
> Using a helper local variable to store the address of >dev adds
> to readability and allows us to avoid unnecessary line breaks.
> 
> Signed-off-by: Bartosz Golaszewski 

Reviewed-by: Matti Vaittinen 

[PATCH] gpio: bd7xxxx: use helper variable for pdev->dev

[Bartosz Golaszewski]

From: Bartosz Golaszewski 

Using a helper local variable to store the address of >dev adds
to readability and allows us to avoid unnecessary line breaks.

Signed-off-by: Bartosz Golaszewski 
---
 drivers/gpio/gpio-bd70528.c | 17 -
 drivers/gpio/gpio-bd71828.c | 15 +++
 2 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/drivers/gpio/gpio-bd70528.c b/drivers/gpio/gpio-bd70528.c
index 276a0fe6346d..397a50d6bc65 100644
--- a/drivers/gpio/gpio-bd70528.c
+++ b/drivers/gpio/gpio-bd70528.c
@@ -181,15 +181,15 @@ static int bd70528_gpio_get(struct gpio_chip *chip, 
unsigned int offset)
 
 static int bd70528_probe(struct platform_device *pdev)
 {
+   struct device *dev = >dev;
struct bd70528_gpio *bdgpio;
int ret;
 
-   bdgpio = devm_kzalloc(>dev, sizeof(*bdgpio),
- GFP_KERNEL);
+   bdgpio = devm_kzalloc(dev, sizeof(*bdgpio), GFP_KERNEL);
if (!bdgpio)
return -ENOMEM;
-   bdgpio->dev = >dev;
-   bdgpio->gpio.parent = pdev->dev.parent;
+   bdgpio->dev = dev;
+   bdgpio->gpio.parent = dev->parent;
bdgpio->gpio.label = "bd70528-gpio";
bdgpio->gpio.owner = THIS_MODULE;
bdgpio->gpio.get_direction = bd70528_get_direction;
@@ -202,16 +202,15 @@ static int bd70528_probe(struct platform_device *pdev)
bdgpio->gpio.ngpio = 4;
bdgpio->gpio.base = -1;
 #ifdef CONFIG_OF_GPIO
-   bdgpio->gpio.of_node = pdev->dev.parent->of_node;
+   bdgpio->gpio.of_node = dev->parent->of_node;
 #endif
-   bdgpio->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+   bdgpio->regmap = dev_get_regmap(dev->parent, NULL);
if (!bdgpio->regmap)
return -ENODEV;
 
-   ret = devm_gpiochip_add_data(>dev, >gpio,
-bdgpio);
+   ret = devm_gpiochip_add_data(dev, >gpio, bdgpio);
if (ret)
-   dev_err(>dev, "gpio_init: Failed to add bd70528-gpio\n");
+   dev_err(dev, "gpio_init: Failed to add bd70528-gpio\n");
 
return ret;
 }
diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c
index fcdcbb57c76d..c8e382b53f2f 100644
--- a/drivers/gpio/gpio-bd71828.c
+++ b/drivers/gpio/gpio-bd71828.c
@@ -97,15 +97,15 @@ static int bd71828_get_direction(struct gpio_chip *chip, 
unsigned int offset)
 
 static int bd71828_probe(struct platform_device *pdev)
 {
+   struct device *dev = >dev;
struct bd71828_gpio *bdgpio;
 
-   bdgpio = devm_kzalloc(>dev, sizeof(*bdgpio),
- GFP_KERNEL);
+   bdgpio = devm_kzalloc(dev, sizeof(*bdgpio), GFP_KERNEL);
if (!bdgpio)
return -ENOMEM;
 
-   bdgpio->dev = >dev;
-   bdgpio->gpio.parent = pdev->dev.parent;
+   bdgpio->dev = dev;
+   bdgpio->gpio.parent = dev->parent;
bdgpio->gpio.label = "bd71828-gpio";
bdgpio->gpio.owner = THIS_MODULE;
bdgpio->gpio.get_direction = bd71828_get_direction;
@@ -121,13 +121,12 @@ static int bd71828_probe(struct platform_device *pdev)
 * "gpio-reserved-ranges" and exclude them from control
 */
bdgpio->gpio.ngpio = 4;
-   bdgpio->gpio.of_node = pdev->dev.parent->of_node;
-   bdgpio->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+   bdgpio->gpio.of_node = dev->parent->of_node;
+   bdgpio->regmap = dev_get_regmap(dev->parent, NULL);
if (!bdgpio->regmap)
return -ENODEV;
 
-   return devm_gpiochip_add_data(>dev, >gpio,
-bdgpio);
+   return devm_gpiochip_add_data(dev, >gpio, bdgpio);
 }
 
 static struct platform_driver bd71828_gpio = {
-- 
2.29.1