Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
On Tue, Aug 28, 2012 at 1:30 PM, Axel Lin wrote: > irq_alloc_descs() returns negative error code on failure. > > Signed-off-by: Axel Lin Applied with Magnus' ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
On Tue, Aug 28, 2012 at 1:30 PM, Axel Lin axel@gmail.com wrote: irq_alloc_descs() returns negative error code on failure. Signed-off-by: Axel Lin axel@gmail.com Applied with Magnus' ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
On Fri, Aug 31, 2012 at 9:05 AM, Linus Walleij wrote: > On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin wrote: > >> irq_alloc_descs() returns negative error code on failure. >> >> Signed-off-by: Axel Lin > > Magnuis can I have your ACK on this? Yes, of course! I never disagree with bug fixes =) Acked-by: Magnus Damm Thanks a lot to both Axel and you! / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin wrote: > irq_alloc_descs() returns negative error code on failure. > > Signed-off-by: Axel Lin Magnuis can I have your ACK on this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin axel@gmail.com wrote: irq_alloc_descs() returns negative error code on failure. Signed-off-by: Axel Lin axel@gmail.com Magnuis can I have your ACK on this? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
On Fri, Aug 31, 2012 at 9:05 AM, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin axel@gmail.com wrote: irq_alloc_descs() returns negative error code on failure. Signed-off-by: Axel Lin axel@gmail.com Magnuis can I have your ACK on this? Yes, of course! I never disagree with bug fixes =) Acked-by: Magnus Damm d...@opensource.se Thanks a lot to both Axel and you! / magnus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] gpio: em: Fix checking return value of irq_alloc_descs
irq_alloc_descs() returns negative error code on failure.
Signed-off-by: Axel Lin
---
drivers/gpio/gpio-em.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index ae37181..ec48ed5 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -247,9 +247,9 @@ static int __devinit em_gio_irq_domain_init(struct
em_gio_priv *p)
p->irq_base = irq_alloc_descs(pdata->irq_base, 0,
pdata->number_of_pins, numa_node_id());
- if (IS_ERR_VALUE(p->irq_base)) {
+ if (p->irq_base < 0) {
dev_err(>dev, "cannot get irq_desc\n");
- return -ENXIO;
+ return p->irq_base;
}
pr_debug("gio: hw base = %d, nr = %d, sw base = %d\n",
pdata->gpio_base, pdata->number_of_pins, p->irq_base);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] gpio: em: Fix checking return value of irq_alloc_descs
irq_alloc_descs() returns negative error code on failure.
Signed-off-by: Axel Lin axel@gmail.com
---
drivers/gpio/gpio-em.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index ae37181..ec48ed5 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -247,9 +247,9 @@ static int __devinit em_gio_irq_domain_init(struct
em_gio_priv *p)
p-irq_base = irq_alloc_descs(pdata-irq_base, 0,
pdata-number_of_pins, numa_node_id());
- if (IS_ERR_VALUE(p-irq_base)) {
+ if (p-irq_base 0) {
dev_err(pdev-dev, cannot get irq_desc\n);
- return -ENXIO;
+ return p-irq_base;
}
pr_debug(gio: hw base = %d, nr = %d, sw base = %d\n,
pdata-gpio_base, pdata-number_of_pins, p-irq_base);
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
