Re: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-14 Thread Linus Walleij
On Thu, Jan 9, 2014 at 11:46 AM, Gerhard Sittig wrote: > Here is why I'm asking: Is there a need from GPIO get_value() > routines to return normalized values, That totally depends. All drivers calling gpio[d]_get_value() will be returned the value directly from the driver without any clamping

Re: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-14 Thread Linus Walleij
On Thu, Jan 9, 2014 at 11:46 AM, Gerhard Sittig g...@denx.de wrote: Here is why I'm asking: Is there a need from GPIO get_value() routines to return normalized values, That totally depends. All drivers calling gpio[d]_get_value() will be returned the value directly from the driver without

RE: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-09 Thread Neil Zhang
ect: Re: [PATCH] gpio: pxa: fix bug when get gpio value > > On Thu, Jan 09, 2014 at 17:25 +0800, Neil Zhang wrote: > > > > gpio_get_value should return 0 or 1. > > > > I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x. > > It's OK

Re: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-09 Thread Gerhard Sittig
On Thu, Jan 09, 2014 at 17:25 +0800, Neil Zhang wrote: > > gpio_get_value should return 0 or 1. > > I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x. > It's OK for all of them to change this function to return 0 and 1. > > [ ... ] > > static int pxa_gpio_get(struct

RE: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-09 Thread Neil Zhang
> -Original Message- > From: Neil Zhang [mailto:zhan...@marvell.com] > Sent: 2014年1月9日 17:26 > To: linus.wall...@linaro.org; gnu...@gmail.com; linux-g...@vger.kernel.org; > linux-ker...@vger.kernel.or > Cc: Neil Zhang > Subject: [PATCH] gpio: pxa: fix bu

RE: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-09 Thread Neil Zhang
-Original Message- From: Neil Zhang [mailto:zhan...@marvell.com] Sent: 2014年1月9日 17:26 To: linus.wall...@linaro.org; gnu...@gmail.com; linux-g...@vger.kernel.org; linux-ker...@vger.kernel.or Cc: Neil Zhang Subject: [PATCH] gpio: pxa: fix bug when get gpio value gpio_get_value

Re: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-09 Thread Gerhard Sittig
On Thu, Jan 09, 2014 at 17:25 +0800, Neil Zhang wrote: gpio_get_value should return 0 or 1. I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x. It's OK for all of them to change this function to return 0 and 1. [ ... ] static int pxa_gpio_get(struct gpio_chip

RE: [PATCH] gpio: pxa: fix bug when get gpio value

2014-01-09 Thread Neil Zhang
bug when get gpio value On Thu, Jan 09, 2014 at 17:25 +0800, Neil Zhang wrote: gpio_get_value should return 0 or 1. I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x. It's OK for all of them to change this function to return 0 and 1. [ ... ] static int