Re: [PATCH] gpiolib: fix filtering out unwanted events

On Thu, Jun 29, 2017 at 1:03 PM, Bartosz Golaszewski wrote: > 2017-06-29 11:33 GMT+02:00 Linus Walleij : >> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski wrote: >> >>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary

Re: [PATCH] gpiolib: fix filtering out unwanted events

On Thu, Jun 29, 2017 at 1:03 PM, Bartosz Golaszewski wrote: > 2017-06-29 11:33 GMT+02:00 Linus Walleij : >> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski wrote: >> >>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of >>> GPIOEVENT_REQUEST_RISING_EDGE and

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 11:33 GMT+02:00 Linus Walleij : > On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski wrote: > >> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of >> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE. >> >>

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 11:33 GMT+02:00 Linus Walleij : > On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski wrote: > >> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of >> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE. >> >> The expression 'le->eflags &

Re: [PATCH] gpiolib: fix filtering out unwanted events

On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski wrote: > GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of > GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE. > > The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get >

Re: [PATCH] gpiolib: fix filtering out unwanted events

On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski wrote: > GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of > GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE. > > The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get > evaluated to true

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-23 13:45 GMT+02:00 Bartosz Golaszewski : > Hi Linux, > s/Linux/Linus :) Bartosz

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-23 13:45 GMT+02:00 Bartosz Golaszewski : > Hi Linux, > s/Linux/Linus :) Bartosz

[PATCH] gpiolib: fix filtering out unwanted events

Hi Linux, I've just fixed an issue in libgpiod which accidentally also led to filtering out unwanted events in user space instead of gpiolib kernel code. I then noticed that programs don't behave correctly and tracked it down to an issue in gpiolib.c. Please take a look at the fix. The bug has

[PATCH] gpiolib: fix filtering out unwanted events

Hi Linux, I've just fixed an issue in libgpiod which accidentally also led to filtering out unwanted events in user space instead of gpiolib kernel code. I then noticed that programs don't behave correctly and tracked it down to an issue in gpiolib.c. Please take a look at the fix. The bug has

[PATCH] gpiolib: fix filtering out unwanted events

GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE. The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get evaluated to true even if only one event type was requested. Fix it by checking both RISING

[PATCH] gpiolib: fix filtering out unwanted events

GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE. The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get evaluated to true even if only one event type was requested. Fix it by checking both RISING