Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-12 Thread Mika Westerberg
On Fri, Apr 12, 2013 at 12:35:05AM +0200, Linus Walleij wrote: > On Thu, Apr 11, 2013 at 9:29 AM, Mika Westerberg > wrote: > > > Grant and Linus W, > > > > Do you have any comments on this patch? Could it still be merged for 3.10? > > No and yes. > > Applied and pushed for linux-next now.

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-12 Thread Mika Westerberg
On Fri, Apr 12, 2013 at 12:35:05AM +0200, Linus Walleij wrote: On Thu, Apr 11, 2013 at 9:29 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Grant and Linus W, Do you have any comments on this patch? Could it still be merged for 3.10? No and yes. Applied and pushed for

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Rafael J. Wysocki
On Friday, April 12, 2013 12:33:55 AM Linus Walleij wrote: > On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg > wrote: > > > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide > > a helper function analogous to Device Tree version that allows drivers to > > specify which

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Linus Walleij
On Thu, Apr 11, 2013 at 9:29 AM, Mika Westerberg wrote: > Grant and Linus W, > > Do you have any comments on this patch? Could it still be merged for 3.10? No and yes. Applied and pushed for linux-next now. Sorry for taking so long, I was confused by the discussion. I had to use some fuzzing

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Linus Walleij
On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg wrote: > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide > a helper function analogous to Device Tree version that allows drivers to > specify which GPIO resource they are interested (using an index to the GPIO >

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Mika Westerberg
On Wed, Apr 03, 2013 at 01:04:26PM +0200, Rafael J. Wysocki wrote: > On Wednesday, April 03, 2013 01:56:54 PM Mika Westerberg wrote: > > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide > > a helper function analogous to Device Tree version that allows drivers to > >

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Mika Westerberg
On Wed, Apr 03, 2013 at 01:04:26PM +0200, Rafael J. Wysocki wrote: On Wednesday, April 03, 2013 01:56:54 PM Mika Westerberg wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows drivers to specify

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Linus Walleij
On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows drivers to specify which GPIO resource they are interested (using

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Linus Walleij
On Thu, Apr 11, 2013 at 9:29 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Grant and Linus W, Do you have any comments on this patch? Could it still be merged for 3.10? No and yes. Applied and pushed for linux-next now. Sorry for taking so long, I was confused by the

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Rafael J. Wysocki
On Friday, April 12, 2013 12:33:55 AM Linus Walleij wrote: On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 12:01:23PM +0200, Benjamin Tissoires wrote: > > One option is to provide acpi_get_gpio_all() that returns all GPIOs and > > their corresponding types. That should allow clients like i2c-hid to find > > the right GPIO (I'm hoping that there will be only one GpioInt

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Benjamin Tissoires
On Thu, Apr 4, 2013 at 11:57 AM, Mika Westerberg wrote: > On Thu, Apr 04, 2013 at 11:42:11AM +0200, Benjamin Tissoires wrote: >> On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg >> wrote: >> > On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: >> >> Hi Mika, >> >> >> >> On Wed,

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:42:11AM +0200, Benjamin Tissoires wrote: > On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg > wrote: > > On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: > >> Hi Mika, > >> > >> On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg > >> wrote: > >> >

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Benjamin Tissoires
On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg wrote: > On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: >> Hi Mika, >> >> On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg >> wrote: >> > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide >> > a

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: > Hi Mika, > > On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg > wrote: > > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide > > a helper function analogous to Device Tree version that allows drivers

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Benjamin Tissoires
Hi Mika, On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg wrote: > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide > a helper function analogous to Device Tree version that allows drivers to > specify which GPIO resource they are interested (using an index to the GPIO

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Benjamin Tissoires
Hi Mika, On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows drivers to specify which GPIO resource they are interested

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: Hi Mika, On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Benjamin Tissoires
On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: Hi Mika, On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Instead of open-coding ACPI GPIO

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:42:11AM +0200, Benjamin Tissoires wrote: On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: Hi Mika, On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Benjamin Tissoires
On Thu, Apr 4, 2013 at 11:57 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Apr 04, 2013 at 11:42:11AM +0200, Benjamin Tissoires wrote: On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Apr 04, 2013 at 11:19:53AM +0200,

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 12:01:23PM +0200, Benjamin Tissoires wrote: One option is to provide acpi_get_gpio_all() that returns all GPIOs and their corresponding types. That should allow clients like i2c-hid to find the right GPIO (I'm hoping that there will be only one GpioInt associated

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-03 Thread Rafael J. Wysocki
On Wednesday, April 03, 2013 01:56:54 PM Mika Westerberg wrote: > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide > a helper function analogous to Device Tree version that allows drivers to > specify which GPIO resource they are interested (using an index to the GPIO >

[PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-03 Thread Mika Westerberg
Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows drivers to specify which GPIO resource they are interested (using an index to the GPIO resources). The function then finds out the correct resource, translates

[PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-03 Thread Mika Westerberg
Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows drivers to specify which GPIO resource they are interested (using an index to the GPIO resources). The function then finds out the correct resource, translates

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-03 Thread Rafael J. Wysocki
On Wednesday, April 03, 2013 01:56:54 PM Mika Westerberg wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows drivers to specify which GPIO resource they are interested (using an index to the GPIO