Re:Re: Re: [PATCH] gpu/drm/mgag200:remove break after return

2020-10-27 Thread Bernard
From: Sam Ravnborg Date: 2020-10-25 01:14:57 To: Bernard Cc: Thomas Zimmermann ,opensource.ker...@vivo.com,David Airlie ,linux-kernel@vger.kernel.org,dri-de...@lists.freedesktop.org,Dave Airlie Subject: Re: Re: [PATCH] gpu/drm/mgag200:remove break after return>Hi Bernard. > >On

Re: Re: [PATCH] gpu/drm/mgag200:remove break after return

2020-10-24 Thread Sam Ravnborg
ensource.ker...@vivo.com > Subject: Re: [PATCH] gpu/drm/mgag200:remove break after return>Hi > > > >On 23.10.20 09:00, Bernard Zhao wrote: > >> In function mgag200_set_pci_regs, there are some switch cases > >> returned, then break. These break will n

Re: [PATCH] gpu/drm/mgag200:remove break after return

2020-10-23 Thread Thomas Zimmermann
ubject: Re: [PATCH] gpu/drm/mgag200:remove break after return>Hi >> >> On 23.10.20 09:00, Bernard Zhao wrote: >>> In function mgag200_set_pci_regs, there are some switch cases >>> returned, then break. These break will never run. >>> This patch is

Re:Re: [PATCH] gpu/drm/mgag200:remove break after return

2020-10-23 Thread Bernard
From: Thomas Zimmermann Date: 2020-10-23 15:13:30 To: Bernard Zhao ,Dave Airlie ,David Airlie ,Daniel Vetter ,dri-de...@lists.freedesktop.org,linux-kernel@vger.kernel.org Cc: opensource.ker...@vivo.com Subject: Re: [PATCH] gpu/drm/mgag200:remove break after return>Hi > >On 23.10

Re: [PATCH] gpu/drm/mgag200:remove break after return

2020-10-23 Thread Thomas Zimmermann
Hi On 23.10.20 09:00, Bernard Zhao wrote: > In function mgag200_set_pci_regs, there are some switch cases > returned, then break. These break will never run. > This patch is to make the code a bit readable. > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 5

[PATCH] gpu/drm/mgag200:remove break after return

2020-10-23 Thread Bernard Zhao
In function mgag200_set_pci_regs, there are some switch cases returned, then break. These break will never run. This patch is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/mgag200/mgag200_mode.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff