Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-11 Thread Andrew Morton
On Mon, 11 Dec 2006 21:44:34 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Andrew Morton a __crit : > > > > hm, the patch seems to transform a mess into a mess. I guess it's a messy > > problem. > > > > I agree that aggregating all the time-related things into a struct like > > this makes

Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-11 Thread Eric Dumazet
Andrew Morton a écrit : hm, the patch seems to transform a mess into a mess. I guess it's a messy problem. I agree that aggregating all the time-related things into a struct like this makes some sense. As does aggregating them all into a similar-looking namespace, but that'd probably be too

Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-11 Thread Eric Dumazet
Andrew Morton a écrit : hm, the patch seems to transform a mess into a mess. I guess it's a messy problem. I agree that aggregating all the time-related things into a struct like this makes some sense. As does aggregating them all into a similar-looking namespace, but that'd probably be too

Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-11 Thread Andrew Morton
On Mon, 11 Dec 2006 21:44:34 +0100 Eric Dumazet [EMAIL PROTECTED] wrote: Andrew Morton a __crit : hm, the patch seems to transform a mess into a mess. I guess it's a messy problem. I agree that aggregating all the time-related things into a struct like this makes some sense. As

Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-08 Thread Randy Dunlap
On Fri, 8 Dec 2006 21:46:25 -0800 Andrew Morton wrote: > On Fri, 8 Dec 2006 17:52:09 +0100 > Eric Dumazet <[EMAIL PROTECTED]> wrote: [snip] > Sounds like you have about three patches there. > > /> > > > > > -extern struct timespec xtime; > > -extern struct timespec wall_to_monotonic; > >

Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-08 Thread Andrew Morton
On Fri, 8 Dec 2006 17:52:09 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > This patch introduces a new structure called ktimed (Kernel Time Data), where > some time keeping related variables are put together to share as few cache > lines as possible. This avoid some false sharing, (since

[PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-08 Thread Eric Dumazet
This patch introduces a new structure called ktimed (Kernel Time Data), where some time keeping related variables are put together to share as few cache lines as possible. This avoid some false sharing, (since linker could put calc_load_count in a *random* cache line for example) I also

[PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-08 Thread Eric Dumazet
This patch introduces a new structure called ktimed (Kernel Time Data), where some time keeping related variables are put together to share as few cache lines as possible. This avoid some false sharing, (since linker could put calc_load_count in a *random* cache line for example) I also

Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-08 Thread Andrew Morton
On Fri, 8 Dec 2006 17:52:09 +0100 Eric Dumazet [EMAIL PROTECTED] wrote: This patch introduces a new structure called ktimed (Kernel Time Data), where some time keeping related variables are put together to share as few cache lines as possible. This avoid some false sharing, (since linker

Re: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed

2006-12-08 Thread Randy Dunlap
On Fri, 8 Dec 2006 21:46:25 -0800 Andrew Morton wrote: On Fri, 8 Dec 2006 17:52:09 +0100 Eric Dumazet [EMAIL PROTECTED] wrote: [snip] Sounds like you have about three patches there. save attachment, read from file, s/^/ / -extern struct timespec xtime; -extern struct timespec