[PATCH] hotplug: make register and unregister notifier API symmetric

From: Michal Hocko Yu Zhao has noticed that __unregister_cpu_notifier only unregisters its notifiers when HOTPLUG_CPU=y while the registration might succeed even when HOTPLUG_CPU=n if MODULE is enabled. This means that e.g. zswap might keep a stale notifier on the list on the

[PATCH] hotplug: make register and unregister notifier API symmetric

From: Michal Hocko Yu Zhao has noticed that __unregister_cpu_notifier only unregisters its notifiers when HOTPLUG_CPU=y while the registration might succeed even when HOTPLUG_CPU=n if MODULE is enabled. This means that e.g. zswap might keep a stale notifier on the list on the manual clean up

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

On Mon 05-12-16 12:59:02, Yu Zhao wrote: > On Fri, Dec 02, 2016 at 04:19:36PM +0100, Michal Hocko wrote: > > [Let's CC more people - the thread started > > http://lkml.kernel.org/r/1480540516-6458-1-git-send-email-yuz...@google.com] > > > > On Fri 02-12-16 09:56:26, Dan Streetman wrote: > > > On

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

On Mon 05-12-16 12:59:02, Yu Zhao wrote: > On Fri, Dec 02, 2016 at 04:19:36PM +0100, Michal Hocko wrote: > > [Let's CC more people - the thread started > > http://lkml.kernel.org/r/1480540516-6458-1-git-send-email-yuz...@google.com] > > > > On Fri 02-12-16 09:56:26, Dan Streetman wrote: > > > On

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

anging /sys/module/zswap/parameters/compressor multiple times will cause: [ 144.964346] BUG: unable to handle kernel paging request at 880658a2be78 [ 144.971337] IP: [] raw_notifier_chain_register+0x1b/0x40 [ 145.122628] Call Trace: [ 145.125086] [] __register_cpu_notifier+0x18/0x20 [ 145.13

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

le times will cause: [ 144.964346] BUG: unable to handle kernel paging request at 880658a2be78 [ 144.971337] IP: [] raw_notifier_chain_register+0x1b/0x40 [ 145.122628] Call Trace: [ 145.125086] [] __register_cpu_notifier+0x18/0x20 [ 145.131350] [] zswap_pool_create+0x273/0x400 [ 145.

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

-- >From 29a6f62ac4407b6e22ce86ac81d3856e5d01fea3 Mon Sep 17 00:00:00 2001 From: Michal Hocko <mho...@suse.com> Date: Fri, 2 Dec 2016 16:06:56 +0100 Subject: [PATCH] hotplug: make register and unregister notifier API symmetric Yu Zhao has noticed that __unregister_cpu_notifier only unregis

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

-- >From 29a6f62ac4407b6e22ce86ac81d3856e5d01fea3 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Fri, 2 Dec 2016 16:06:56 +0100 Subject: [PATCH] hotplug: make register and unregister notifier API symmetric Yu Zhao has noticed that __unregister_cpu_notifier only unregisters its notifiers

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

Hi Michal, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

Hi Michal, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

Hi Michal, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] hotplug: make register and unregister notifier API symmetric

Hi Michal, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] hotplug: make register and unregister notifier API symmetric

sts that __unregister_cpu_notifier should > >> the the symmetric thing to the __register_cpu_notifier for > >> CONFIG_MODULE, right? > > > > I meant the following. Completely untested > > agreed, but also needs the non-__ version, and kernel/cpu.c needs > tweak

[PATCH] hotplug: make register and unregister notifier API symmetric

; >> the the symmetric thing to the __register_cpu_notifier for > >> CONFIG_MODULE, right? > > > > I meant the following. Completely untested > > agreed, but also needs the non-__ version, and kernel/cpu.c needs > tweaking to move those functions out of the #ifdef