Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-04-09 Thread Adrian Bunk
On Wed, Apr 04, 2007 at 11:30:48PM +0200, Thomas Gleixner wrote: > On Wed, 2007-04-04 at 23:11 +0200, Adrian Bunk wrote: > > On Wed, Mar 14, 2007 at 11:00:12AM +0100, Thomas Gleixner wrote: > > > hrtimer_forward() does not check for the possible overflow of > > > timer->expires. This can happen on

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-04-09 Thread Adrian Bunk
On Wed, Apr 04, 2007 at 11:30:48PM +0200, Thomas Gleixner wrote: On Wed, 2007-04-04 at 23:11 +0200, Adrian Bunk wrote: On Wed, Mar 14, 2007 at 11:00:12AM +0100, Thomas Gleixner wrote: hrtimer_forward() does not check for the possible overflow of timer-expires. This can happen on 64 bit

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-04-04 Thread Thomas Gleixner
On Wed, 2007-04-04 at 23:11 +0200, Adrian Bunk wrote: > On Wed, Mar 14, 2007 at 11:00:12AM +0100, Thomas Gleixner wrote: > > hrtimer_forward() does not check for the possible overflow of > > timer->expires. This can happen on 64 bit machines with large interval > > values and results currently in

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-04-04 Thread Adrian Bunk
On Wed, Mar 14, 2007 at 11:00:12AM +0100, Thomas Gleixner wrote: > hrtimer_forward() does not check for the possible overflow of > timer->expires. This can happen on 64 bit machines with large interval > values and results currently in an endless loop in the softirq because > the expiry value

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-04-04 Thread Adrian Bunk
On Wed, Mar 14, 2007 at 11:00:12AM +0100, Thomas Gleixner wrote: hrtimer_forward() does not check for the possible overflow of timer-expires. This can happen on 64 bit machines with large interval values and results currently in an endless loop in the softirq because the expiry value becomes

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-04-04 Thread Thomas Gleixner
On Wed, 2007-04-04 at 23:11 +0200, Adrian Bunk wrote: On Wed, Mar 14, 2007 at 11:00:12AM +0100, Thomas Gleixner wrote: hrtimer_forward() does not check for the possible overflow of timer-expires. This can happen on 64 bit machines with large interval values and results currently in an

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Chuck Ebbert
Thomas Gleixner wrote: > On Sun, 2007-03-18 at 17:53 -0400, Chuck Ebbert wrote: Just to be clear: this replaces the earlier patch, right? >>> This replaces the fix Andrew did. >>> >>> http://marc.info/?l=linux-kernel=117407812411997=2 >>> >> Right, but is the original "Prevent DOS" patch from

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Thomas Gleixner
On Sun, 2007-03-18 at 17:53 -0400, Chuck Ebbert wrote: > >> Just to be clear: this replaces the earlier patch, right? > > > > This replaces the fix Andrew did. > > > > http://marc.info/?l=linux-kernel=117407812411997=2 > > > > Right, but is the original "Prevent DOS" patch from you still

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Chuck Ebbert
Thomas Gleixner wrote: > On Sun, 2007-03-18 at 17:16 -0400, Chuck Ebbert wrote: >> Thomas Gleixner wrote: >>> I'd prefer this one: The maximum seconds value we can handle on 32bit is >>> LONG_MAX. >>> >>> diff --git a/include/linux/ktime.h b/include/linux/ktime.h >>> index c68c7ac..248305b 100644

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Thomas Gleixner
On Sun, 2007-03-18 at 17:16 -0400, Chuck Ebbert wrote: > Thomas Gleixner wrote: > > > > I'd prefer this one: The maximum seconds value we can handle on 32bit is > > LONG_MAX. > > > > diff --git a/include/linux/ktime.h b/include/linux/ktime.h > > index c68c7ac..248305b 100644 > > ---

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Chuck Ebbert
Thomas Gleixner wrote: > > I'd prefer this one: The maximum seconds value we can handle on 32bit is > LONG_MAX. > > diff --git a/include/linux/ktime.h b/include/linux/ktime.h > index c68c7ac..248305b 100644 > --- a/include/linux/ktime.h > +++ b/include/linux/ktime.h > @@ -57,7 +57,11 @@ typedef

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Chuck Ebbert
Thomas Gleixner wrote: I'd prefer this one: The maximum seconds value we can handle on 32bit is LONG_MAX. diff --git a/include/linux/ktime.h b/include/linux/ktime.h index c68c7ac..248305b 100644 --- a/include/linux/ktime.h +++ b/include/linux/ktime.h @@ -57,7 +57,11 @@ typedef union {

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Thomas Gleixner
On Sun, 2007-03-18 at 17:16 -0400, Chuck Ebbert wrote: Thomas Gleixner wrote: I'd prefer this one: The maximum seconds value we can handle on 32bit is LONG_MAX. diff --git a/include/linux/ktime.h b/include/linux/ktime.h index c68c7ac..248305b 100644 --- a/include/linux/ktime.h

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Chuck Ebbert
Thomas Gleixner wrote: On Sun, 2007-03-18 at 17:16 -0400, Chuck Ebbert wrote: Thomas Gleixner wrote: I'd prefer this one: The maximum seconds value we can handle on 32bit is LONG_MAX. diff --git a/include/linux/ktime.h b/include/linux/ktime.h index c68c7ac..248305b 100644 ---

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Thomas Gleixner
On Sun, 2007-03-18 at 17:53 -0400, Chuck Ebbert wrote: Just to be clear: this replaces the earlier patch, right? This replaces the fix Andrew did. http://marc.info/?l=linux-kernelm=117407812411997w=2 Right, but is the original Prevent DOS patch from you still needed? Or did

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-18 Thread Chuck Ebbert
Thomas Gleixner wrote: On Sun, 2007-03-18 at 17:53 -0400, Chuck Ebbert wrote: Just to be clear: this replaces the earlier patch, right? This replaces the fix Andrew did. http://marc.info/?l=linux-kernelm=117407812411997w=2 Right, but is the original Prevent DOS patch from you still needed?

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-16 Thread Thomas Gleixner
On Fri, 2007-03-16 at 12:43 -0800, Andrew Morton wrote: > On Wed, 14 Mar 2007 11:00:12 +0100 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > rtimer_forward() does not check for the possible overflow of > > timer->expires. This can happen on 64 bit machines with large interval > > values and

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-16 Thread Andrew Morton
On Wed, 14 Mar 2007 11:00:12 +0100 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > rtimer_forward() does not check for the possible overflow of > timer->expires. This can happen on 64 bit machines with large interval > values and results currently in an endless loop in the softirq because > the

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-16 Thread Andrew Morton
On Wed, 14 Mar 2007 11:00:12 +0100 Thomas Gleixner [EMAIL PROTECTED] wrote: rtimer_forward() does not check for the possible overflow of timer-expires. This can happen on 64 bit machines with large interval values and results currently in an endless loop in the softirq because the expiry

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-16 Thread Thomas Gleixner
On Fri, 2007-03-16 at 12:43 -0800, Andrew Morton wrote: On Wed, 14 Mar 2007 11:00:12 +0100 Thomas Gleixner [EMAIL PROTECTED] wrote: rtimer_forward() does not check for the possible overflow of timer-expires. This can happen on 64 bit machines with large interval values and results

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-14 Thread Ingo Molnar
* Thomas Gleixner <[EMAIL PROTECTED]> wrote: > hrtimer_forward() does not check for the possible overflow of > timer->expires. This can happen on 64 bit machines with large interval > values and results currently in an endless loop in the softirq because > the expiry value becomes negative

[PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-14 Thread Thomas Gleixner
hrtimer_forward() does not check for the possible overflow of timer->expires. This can happen on 64 bit machines with large interval values and results currently in an endless loop in the softirq because the expiry value becomes negative and therefor the timer is expired all the time. Check for

[PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-14 Thread Thomas Gleixner
hrtimer_forward() does not check for the possible overflow of timer-expires. This can happen on 64 bit machines with large interval values and results currently in an endless loop in the softirq because the expiry value becomes negative and therefor the timer is expired all the time. Check for

Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

2007-03-14 Thread Ingo Molnar
* Thomas Gleixner [EMAIL PROTECTED] wrote: hrtimer_forward() does not check for the possible overflow of timer-expires. This can happen on 64 bit machines with large interval values and results currently in an endless loop in the softirq because the expiry value becomes negative and