Re: [PATCH] i2c: core: squelch error: uninitialized symbol 'ret'

2018-10-05 Thread George G. Davis
On Fri, Oct 05, 2018 at 07:43:01PM +0200, Wolfram Sang wrote: > > > Feel free to ignore if this is a topic already discussed in other > > threads. To be honest, I did not search the mailing list to determine if > > this particular issue was already discussed. > > Not this particular issue, but

Re: [PATCH] i2c: core: squelch error: uninitialized symbol 'ret'

2018-10-05 Thread Wolfram Sang
> Feel free to ignore if this is a topic already discussed in other > threads. To be honest, I did not search the mailing list to determine if > this particular issue was already discussed. Not this particular issue, but in general we usually don't change working code to silence false positives

Re: [PATCH] i2c: core: squelch error: uninitialized symbol 'ret'

2018-10-05 Thread George G. Davis
On Fri, Oct 05, 2018 at 06:28:41PM +0200, Wolfram Sang wrote: > On Fri, Oct 05, 2018 at 12:18:25PM -0400, George G. Davis wrote: > > The following smatch error was introduced by commit 7ca5f6be7900 ("i2c: > > recovery: add get_bus_free callback"): > > > > drivers/i2c/i2c-core-base.c:228 i2c_generi

Re: [PATCH] i2c: core: squelch error: uninitialized symbol 'ret'

2018-10-05 Thread Wolfram Sang
On Fri, Oct 05, 2018 at 12:18:25PM -0400, George G. Davis wrote: > The following smatch error was introduced by commit 7ca5f6be7900 ("i2c: > recovery: add get_bus_free callback"): > > drivers/i2c/i2c-core-base.c:228 i2c_generic_scl_recovery() error: > uninitialized symbol 'ret'. > > Analysis of

[PATCH] i2c: core: squelch error: uninitialized symbol 'ret'

2018-10-05 Thread George G. Davis
The following smatch error was introduced by commit 7ca5f6be7900 ("i2c: recovery: add get_bus_free callback"): drivers/i2c/i2c-core-base.c:228 i2c_generic_scl_recovery() error: uninitialized symbol 'ret'. Analysis of the code appears to show that the smatch error is a false positive since 'ret'