On Tue, Mar 17, 2015 at 03:51:13AM -0400, Nicholas Mc Guire wrote:
> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the
> check
> for >= 0 is always true and can be dropped implying that r==-EREMOTEIO and
> thus
> the return of -EREMOTEIO can be done in the if
On Tue, Mar 17, 2015 at 03:51:13AM -0400, Nicholas Mc Guire wrote:
wait_for_completion_timeout return 0 (timeout) or =1 (completion) so the
check
for = 0 is always true and can be dropped implying that r==-EREMOTEIO and
thus
the return of -EREMOTEIO can be done in the if (dev-buf_len)
Hi!
On 17/03/15 08:51, ext Nicholas Mc Guire wrote:
> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the
> check
> for >= 0 is always true and can be dropped implying that r==-EREMOTEIO and
> thus
> the return of -EREMOTEIO can be done in the if (dev->buf_len) branch.
wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check
for >= 0 is always true and can be dropped implying that r==-EREMOTEIO and thus
the return of -EREMOTEIO can be done in the if (dev->buf_len) branch.
As wait_for_completion_timeout returns unsigned long not int, and
wait_for_completion_timeout return 0 (timeout) or =1 (completion) so the check
for = 0 is always true and can be dropped implying that r==-EREMOTEIO and thus
the return of -EREMOTEIO can be done in the if (dev-buf_len) branch.
As wait_for_completion_timeout returns unsigned long not int, and
Hi!
On 17/03/15 08:51, ext Nicholas Mc Guire wrote:
wait_for_completion_timeout return 0 (timeout) or =1 (completion) so the
check
for = 0 is always true and can be dropped implying that r==-EREMOTEIO and
thus
the return of -EREMOTEIO can be done in the if (dev-buf_len) branch.
As
6 matches
Mail list logo
