Re: [PATCH] i2c: generic recovery: check SCL before SDA

2017-10-28 Thread Wolfram Sang
On Thu, Oct 05, 2017 at 02:44:14PM +0200, Claudio Foellmi wrote: > Move the check for a stuck SCL before the check for a high SDA. > This prevent false positives in the specific case that SDA is fine > and SCL is stuck, which previously returned 0. > > Also check SDA again after the loop, if we

Re: [PATCH] i2c: generic recovery: check SCL before SDA

2017-10-28 Thread Wolfram Sang
On Thu, Oct 05, 2017 at 02:44:14PM +0200, Claudio Foellmi wrote: > Move the check for a stuck SCL before the check for a high SDA. > This prevent false positives in the specific case that SDA is fine > and SCL is stuck, which previously returned 0. > > Also check SDA again after the loop, if we

[PATCH] i2c: generic recovery: check SCL before SDA

2017-10-05 Thread Claudio Foellmi
Move the check for a stuck SCL before the check for a high SDA. This prevent false positives in the specific case that SDA is fine and SCL is stuck, which previously returned 0. Also check SDA again after the loop, if we can. Together, these changes should lead to a lot more failed recoveries

[PATCH] i2c: generic recovery: check SCL before SDA

2017-10-05 Thread Claudio Foellmi
Move the check for a stuck SCL before the check for a high SDA. This prevent false positives in the specific case that SDA is fine and SCL is stuck, which previously returned 0. Also check SDA again after the loop, if we can. Together, these changes should lead to a lot more failed recoveries