Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-13 Thread Mike Looijmans
On 13-01-17 09:37, Wolfram Sang wrote: I would argue that the "info" message means "the I2C adapter is ready for transaction now, and we'll start initializing devices on the bus". That is the case before it calls i2c_add_adapter(). I know what you mean, but i2c_add_adapter does more, and it

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-13 Thread Mike Looijmans
On 13-01-17 09:37, Wolfram Sang wrote: I would argue that the "info" message means "the I2C adapter is ready for transaction now, and we'll start initializing devices on the bus". That is the case before it calls i2c_add_adapter(). I know what you mean, but i2c_add_adapter does more, and it

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-13 Thread Wolfram Sang
> I would argue that the "info" message means "the I2C adapter is ready for > transaction now, and we'll start initializing devices on the bus". That is > the case before it calls i2c_add_adapter(). I know what you mean, but i2c_add_adapter does more, and it can fail because the adapter is *not*

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-13 Thread Wolfram Sang
> I would argue that the "info" message means "the I2C adapter is ready for > transaction now, and we'll start initializing devices on the bus". That is > the case before it calls i2c_add_adapter(). I know what you mean, but i2c_add_adapter does more, and it can fail because the adapter is *not*

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-12 Thread Mike Looijmans
On 06-01-17 22:34, Vladimir Zapolskiy wrote: Hello Mike, On 01/05/2017 12:47 PM, Mike Looijmans wrote: The driver calls i2c_add_adapter before writing to config registers, resulting in dmesg output like this, where devices fail to initialize: cdns-i2c ff03.i2c: timeout waiting on

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-12 Thread Mike Looijmans
On 06-01-17 22:34, Vladimir Zapolskiy wrote: Hello Mike, On 01/05/2017 12:47 PM, Mike Looijmans wrote: The driver calls i2c_add_adapter before writing to config registers, resulting in dmesg output like this, where devices fail to initialize: cdns-i2c ff03.i2c: timeout waiting on

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-12 Thread Wolfram Sang
> Because the adapter registration i2c_add_adapter() can fail, information > about the adapter initialization would be expected only in case of > successful registration. Exactly. > > The information sent to the kernel log buffer here is quite trivial, > probably dev_info() can be just

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-12 Thread Wolfram Sang
> Because the adapter registration i2c_add_adapter() can fail, information > about the adapter initialization would be expected only in case of > successful registration. Exactly. > > The information sent to the kernel log buffer here is quite trivial, > probably dev_info() can be just

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-06 Thread Vladimir Zapolskiy
Hello Mike, On 01/05/2017 12:47 PM, Mike Looijmans wrote: > The driver calls i2c_add_adapter before writing to config registers, > resulting in dmesg output like this, where devices fail to initialize: > > cdns-i2c ff03.i2c: timeout waiting on completion > pca953x 1-0041: failed reading

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-06 Thread Vladimir Zapolskiy
Hello Mike, On 01/05/2017 12:47 PM, Mike Looijmans wrote: > The driver calls i2c_add_adapter before writing to config registers, > resulting in dmesg output like this, where devices fail to initialize: > > cdns-i2c ff03.i2c: timeout waiting on completion > pca953x 1-0041: failed reading

[PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-05 Thread Mike Looijmans
The driver calls i2c_add_adapter before writing to config registers, resulting in dmesg output like this, where devices fail to initialize: cdns-i2c ff03.i2c: timeout waiting on completion pca953x 1-0041: failed reading register pca953x: probe of 1-0041 failed with error -110 at24 1-0050: 512

[PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-05 Thread Mike Looijmans
The driver calls i2c_add_adapter before writing to config registers, resulting in dmesg output like this, where devices fail to initialize: cdns-i2c ff03.i2c: timeout waiting on completion pca953x 1-0041: failed reading register pca953x: probe of 1-0041 failed with error -110 at24 1-0050: 512