Re: [PATCH] i2c: i801: mark PM functions as __maybe_unused

2018-05-25 Thread Wolfram Sang
On Fri, May 25, 2018 at 11:09:46PM +0200, Arnd Bergmann wrote: > Changing from UNIVERSAL_DEV_PM_OPS to SIMPLE_DEV_PM_OPS caused a harmless > warning in configurations without CONFIG_PM_SLEEP: > > drivers/i2c/busses/i2c-i801.c:1723:12: error: 'i801_resume' defined but not > used

[PATCH] i2c: i801: mark PM functions as __maybe_unused

2018-05-25 Thread Arnd Bergmann
Changing from UNIVERSAL_DEV_PM_OPS to SIMPLE_DEV_PM_OPS caused a harmless warning in configurations without CONFIG_PM_SLEEP: drivers/i2c/busses/i2c-i801.c:1723:12: error: 'i801_resume' defined but not used [-Werror=unused-function] static int i801_resume(struct device *dev)

Re: [PATCH] i2c: i801: mark PM functions as __maybe_unused

2018-05-10 Thread Jean Delvare
On Wed, 9 May 2018 19:00:55 +0200, Jean Delvare wrote: > If SIMPLE_DEV_PM_OPS causes it but UNIVERSAL_DEV_PM_OPS did not, I > suppose that what matters is CONFIG_PM_SLEEP. > > So maybe we can just replace "#ifdef CONFIG_PM" with "ifdef > CONFIG_PM_SLEEP" in the code below? It seems that drivers

Re: [PATCH] i2c: i801: mark PM functions as __maybe_unused

2018-05-09 Thread Jean Delvare
Hi Anders, On Tue, 8 May 2018 09:38:52 +0200, Anders Roxell wrote: > With CONFIG_PM, we get a harmless build warning: > drivers/i2c/busses/i2c-i801.c:1723:12: warning: ‘i801_resume’ defined but not > used [-Wunused-function] > static int i801_resume(struct device *dev) >

[PATCH] i2c: i801: mark PM functions as __maybe_unused

2018-05-08 Thread Anders Roxell
With CONFIG_PM, we get a harmless build warning: drivers/i2c/busses/i2c-i801.c:1723:12: warning: ‘i801_resume’ defined but not used [-Wunused-function] static int i801_resume(struct device *dev) ^~~ drivers/i2c/busses/i2c-i801.c:1714:12: warning: ‘i801_suspend’ defined but