Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-05-11 Thread Peter Griffin
Hi Wolfram, On Sun, 24 Apr 2016, Wolfram Sang wrote: > > +/* > > + * i2c bus recovery routines > > + * get_scl and set_scl must be defined to avoid the recover_bus field of > > + * i2c_bus_recovery_info to be overriden with NULL during the > > + * i2c_add_adapter call > > + */ > > Oh, that

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-05-11 Thread Peter Griffin
Hi Wolfram, On Sun, 24 Apr 2016, Wolfram Sang wrote: > > +/* > > + * i2c bus recovery routines > > + * get_scl and set_scl must be defined to avoid the recover_bus field of > > + * i2c_bus_recovery_info to be overriden with NULL during the > > + * i2c_add_adapter call > > + */ > > Oh, that

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-05-11 Thread Peter Griffin
Hi Wolfram, On Wed, 11 May 2016, Wolfram Sang wrote: > > Yes I'll send a v2 with your comment added. > > Any news? > Sorry, I will re-send it in a few minutes. Peter.

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-05-11 Thread Peter Griffin
Hi Wolfram, On Wed, 11 May 2016, Wolfram Sang wrote: > > Yes I'll send a v2 with your comment added. > > Any news? > Sorry, I will re-send it in a few minutes. Peter.

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-05-11 Thread Wolfram Sang
> Yes I'll send a v2 with your comment added. Any news? signature.asc Description: PGP signature

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-05-11 Thread Wolfram Sang
> Yes I'll send a v2 with your comment added. Any news? signature.asc Description: PGP signature

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-29 Thread Peter Griffin
Hi Maxime, On Fri, 29 Apr 2016, Maxime Coquelin wrote: > > > On 04/28/2016 04:57 PM, Wolfram Sang wrote: > >>The trick is to switch to SPI mode, 9 bits words and write a 0, > >>so that 9 clock pulses are generated. > >Heh. As long as it works :) But as you said, it really needs a comment. > >

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-29 Thread Peter Griffin
Hi Maxime, On Fri, 29 Apr 2016, Maxime Coquelin wrote: > > > On 04/28/2016 04:57 PM, Wolfram Sang wrote: > >>The trick is to switch to SPI mode, 9 bits words and write a 0, > >>so that 9 clock pulses are generated. > >Heh. As long as it works :) But as you said, it really needs a comment. > >

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-29 Thread Maxime Coquelin
On 04/28/2016 04:57 PM, Wolfram Sang wrote: The trick is to switch to SPI mode, 9 bits words and write a 0, so that 9 clock pulses are generated. Heh. As long as it works :) But as you said, it really needs a comment. :) I didn't faced the problem myself, but it looks good with an

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-29 Thread Maxime Coquelin
On 04/28/2016 04:57 PM, Wolfram Sang wrote: The trick is to switch to SPI mode, 9 bits words and write a 0, so that 9 clock pulses are generated. Heh. As long as it works :) But as you said, it really needs a comment. :) I didn't faced the problem myself, but it looks good with an

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-28 Thread Wolfram Sang
> The trick is to switch to SPI mode, 9 bits words and write a 0, > so that 9 clock pulses are generated. Heh. As long as it works :) But as you said, it really needs a comment. signature.asc Description: PGP signature

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-28 Thread Wolfram Sang
> The trick is to switch to SPI mode, 9 bits words and write a 0, > so that 9 clock pulses are generated. Heh. As long as it works :) But as you said, it really needs a comment. signature.asc Description: PGP signature

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-28 Thread Maxime Coquelin
Hi Wolfram, On 04/24/2016 11:10 PM, Wolfram Sang wrote: +/* + * i2c bus recovery routines + * get_scl and set_scl must be defined to avoid the recover_bus field of + * i2c_bus_recovery_info to be overriden with NULL during the + * i2c_add_adapter call + */ Oh, that shouldn't be like this. Can

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-28 Thread Maxime Coquelin
Hi Wolfram, On 04/24/2016 11:10 PM, Wolfram Sang wrote: +/* + * i2c bus recovery routines + * get_scl and set_scl must be defined to avoid the recover_bus field of + * i2c_bus_recovery_info to be overriden with NULL during the + * i2c_add_adapter call + */ Oh, that shouldn't be like this. Can

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-24 Thread Wolfram Sang
> +/* > + * i2c bus recovery routines > + * get_scl and set_scl must be defined to avoid the recover_bus field of > + * i2c_bus_recovery_info to be overriden with NULL during the > + * i2c_add_adapter call > + */ Oh, that shouldn't be like this. Can you try this patch and remove the empty

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-24 Thread Wolfram Sang
> +/* > + * i2c bus recovery routines > + * get_scl and set_scl must be defined to avoid the recover_bus field of > + * i2c_bus_recovery_info to be overriden with NULL during the > + * i2c_add_adapter call > + */ Oh, that shouldn't be like this. Can you try this patch and remove the empty

[PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-12 Thread Peter Griffin
>From I2C specification: http://www.nxp.com/documents/user_manual/UM10204.pdf Rev. 03 section 3.1.16 titled "Bus clear". When the i2c device held the SDA line low, the master should send 9 clocks pulses to try to recover. Signed-off-by: Frederic Pillon Signed-off-by:

[PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-12 Thread Peter Griffin
>From I2C specification: http://www.nxp.com/documents/user_manual/UM10204.pdf Rev. 03 section 3.1.16 titled "Bus clear". When the i2c device held the SDA line low, the master should send 9 clocks pulses to try to recover. Signed-off-by: Frederic Pillon Signed-off-by: Peter Griffin ---