Re: [PATCH] i2c: uniphier[-f]: fix bool logic calculation

2016-12-21 Thread Masahiro Yamada
Hi Joe, 2016-12-21 2:55 GMT+09:00 Joe Perches : > On Wed, 2016-12-21 at 01:20 +0900, Masahiro Yamada wrote: >> Hi. >> >> I have not got any comment, but does this seem >> a right thing to do? > >> This code is working, but it should not depend on how "bool" is >> typedef'ed, or the bit position o

Re: [PATCH] i2c: uniphier[-f]: fix bool logic calculation

2016-12-20 Thread Joe Perches
On Wed, 2016-12-21 at 01:20 +0900, Masahiro Yamada wrote: > Hi. > > I have not got any comment, but does this seem > a right thing to do? > This code is working, but it should not depend on how "bool" is > typedef'ed, or the bit position of I2C_M_RD. I think bool can be guaranteed to be _Bool.

Re: [PATCH] i2c: uniphier[-f]: fix bool logic calculation

2016-12-20 Thread Masahiro Yamada
Hi. I have not got any comment, but does this seem a right thing to do? 2016-10-19 13:38 GMT+09:00 Masahiro Yamada : > This code is working, but it should not depend on how "bool" is > typedef'ed, or the bit position of I2C_M_RD. > > Signed-off-by: Masahiro Yamada > --- > > drivers/i2c/busses/i

[PATCH] i2c: uniphier[-f]: fix bool logic calculation

2016-10-18 Thread Masahiro Yamada
This code is working, but it should not depend on how "bool" is typedef'ed, or the bit position of I2C_M_RD. Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier-f.c | 2 +- drivers/i2c/busses/i2c-uniphier.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/