[PATCH] i386: Prevent early access to TSC to avoid crash on TSCless systems

2007-03-24 Thread Thomas Gleixner
commit f9690982b8c2f9a2c65acdc113e758ec356676a3 removed the check for cpu_khz from sched_clock(), which prevented early access to the TSC by non obvious magic. This is harmless as long as the CPU has a TSC. On TSCless systems this results in an illegal instruction trap. Replace tsc_disabled and

Re: [PATCH] i386: Prevent early access to TSC to avoid crash on TSCless systems

2007-03-24 Thread Ingo Molnar
* Thomas Gleixner [EMAIL PROTECTED] wrote: commit f9690982b8c2f9a2c65acdc113e758ec356676a3 removed the check for cpu_khz from sched_clock(), which prevented early access to the TSC by non obvious magic. This is harmless as long as the CPU has a TSC. On TSCless systems this results in

Re: [PATCH] i386: Prevent early access to TSC to avoid crash on TSCless systems

2007-03-24 Thread Guillaume Chazarain
+static int tsc_enabled; So, now we have tsc_disable, tsc_enabled and tsc_unstable. I can understand the latter, but this lacks orthogonality IMHO. -- Guillaume - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] i386: Prevent early access to TSC to avoid crash on TSCless systems

2007-03-24 Thread Ingo Molnar
* Guillaume Chazarain [EMAIL PROTECTED] wrote: +static int tsc_enabled; So, now we have tsc_disable, tsc_enabled and tsc_unstable. I can understand the latter, but this lacks orthogonality IMHO. tsc_disable should be renamed to tsc_disable_override or so, to signal that it's only the